Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Problem with São Paulo - SP in 2024 #34

Open
eduardocorrearaujo opened this issue Feb 19, 2025 · 3 comments
Open

bug: Problem with São Paulo - SP in 2024 #34

eduardocorrearaujo opened this issue Feb 19, 2025 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@eduardocorrearaujo
Copy link
Collaborator

Here, we define the maximum cumulative cases as 5e5. However, in São Paulo - SP in 2024, we had more than 1e6 cases. So, I was wondering whether we should create an exception just for this city or increase the upper threshold for all cities. What do you think, @fccoelho?

Image

@eduardocorrearaujo eduardocorrearaujo self-assigned this Feb 19, 2025
@fccoelho
Copy link
Contributor

I think the best we can do is to set this maximum value from the data (plus 5%) we are fitting, because we are fitting retrospectively, so we already know the value.

@fccoelho fccoelho added the bug Something isn't working label Feb 19, 2025
@eduardocorrearaujo
Copy link
Collaborator Author

I think that it would work for the past years, but I think that would decrease the performance of the fitting in the current year

@fccoelho
Copy link
Contributor

The fit for the current year is only accurate after a certain week. Since we re-run the fit every week, we can set the max range for the optimizer to the maximum in the data + 20%, and it will improve the fit gradually until perfect at the end of the year.

For the current year, we should also add the interactive fit plot that we talked about, so that users can explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants