Move useless calls to official static method

Author: AlexProgrammerDE

server/src/main/java/com/soulfiremc/server/plugins/POVServer.java

@@ -29,7 +29,6 @@
 import com.soulfiremc.server.protocol.BotConnection;
 import com.soulfiremc.server.protocol.BuiltInKnownPackRegistry;
 import com.soulfiremc.server.protocol.SFProtocolConstants;
-import com.soulfiremc.server.protocol.SFProtocolHelper;
 import com.soulfiremc.server.protocol.bot.container.ContainerSlot;
 import com.soulfiremc.server.protocol.bot.model.ChunkKey;
 import com.soulfiremc.server.protocol.bot.state.LevelHeightAccessor;
@@ -438,7 +437,7 @@ private static void syncBotAndUser(BotConnection botConnection, Session clientSe
       var buf = Unpooled.buffer();
 
       for (var i = 0; i < chunk.getSectionCount(); i++) {
-        SFProtocolHelper.writeChunkSection(buf, chunk.getSection(i));
+        MinecraftTypes.writeChunkSection(buf, chunk.getSection(i));
       }
 
       var chunkBytes = new byte[buf.readableBytes()];
@@ -735,7 +734,7 @@ public int getMinY() {
         chunk.set(0, 0, 0, 0);
         var biome = DataPalette.createForBiome();
         biome.set(0, 0, 0, 0);
-        SFProtocolHelper.writeChunkSection(buf, new ChunkSection(0, chunk, biome));
+        MinecraftTypes.writeChunkSection(buf, new ChunkSection(0, chunk, biome));
       }
 
       var chunkBytes = new byte[buf.readableBytes()];

server/src/main/java/com/soulfiremc/server/protocol/SFProtocolHelper.java

@@ -26,7 +26,6 @@
 import com.soulfiremc.server.protocol.BotConnection;
 import com.soulfiremc.server.protocol.BuiltInKnownPackRegistry;
 import com.soulfiremc.server.protocol.SFProtocolConstants;
-import com.soulfiremc.server.protocol.SFProtocolHelper;
 import com.soulfiremc.server.protocol.bot.container.SFItemStack;
 import com.soulfiremc.server.protocol.bot.container.WindowContainer;
 import com.soulfiremc.server.protocol.bot.model.ChunkKey;
@@ -100,7 +99,6 @@
 import org.jetbrains.annotations.Nullable;
 import org.slf4j.Logger;
 
-import java.io.IOException;
 import java.net.MalformedURLException;
 import java.net.URI;
 import java.util.*;
@@ -782,12 +780,8 @@ public void onChunkData(ClientboundLevelChunkWithLightPacket packet) {
 
     var chunkData = level.chunks().getOrCreateChunkSection(packet.getX(), packet.getZ());
 
-    try {
-      for (var i = 0; i < chunkData.getSectionCount(); i++) {
-        chunkData.setSection(i, SFProtocolHelper.readChunkSection(buf));
-      }
-    } catch (IOException e) {
-      log.error("Failed to read chunk section", e);
+    for (var i = 0; i < chunkData.getSectionCount(); i++) {
+      chunkData.setSection(i, MinecraftTypes.readChunkSection(buf));
     }
   }