2 issues in Linked List

[prakashn27]

1. I get 0 entry by default in the linked list.
   if i add 10 i get an entry of 10 , 0

2. insert tail is not working
   i followed the same concept as insert first but it is not working

[prakashn27]

this is in LinkedList.java
FYI i changed my implementation in LinkedListNode.java but wanted to know where i go wrong

[santhoshvai]

this issue is only in java file right? Cos i remember that i tested my c files

[santhoshvai]

And seperate the java implementation and c implementation by separate folders if you can

[santhoshvai]

I have fixed the issue with the new commit, do a git pull origin master to get it

[santhoshvai]

the issue is with

Node head = new Node();
Node tail = new Node();

this means that the head is never null and you cant enter the if loop in line 25. since head and tail have global scope just declaring them is enough to assigning null to the object. I hope this answers your question. LinkedList.java is an elegant implementation in my opinion than the other one. Do implement some JUnit test cases for the code and push it in the repo soon.

[santhoshvai]

for this reason the constructor is also useless!

[santhoshvai]

We can improve the elgance more by using Null object pattern.. this eliminates the risk of comparing null and would have saved you from this issue in the first place... Take this is as a small exercise and implement this code with this pattern. I leave this to you.