Fix lack of matching SDL_free for SDL_GetClipboardText.

Author: AliceLR

src/editor/clipboard.h

@@ -27,6 +27,7 @@ __M_BEGIN_DECLS
 void copy_buffer_to_clipboard(char **buffer, int lines, int total_length);
 
 char *get_clipboard_buffer(void);
+void free_clipboard_buffer(char *buffer);
 
 __M_END_DECLS
 

src/editor/clipboard_carbon.c

@@ -125,7 +125,7 @@ char *get_clipboard_buffer(void)
       src_data = (char *)CFDataGetBytePtr(flavorData);
       length = (size_t)CFDataGetLength(flavorData);
 
-      dest_data = cmalloc(length + 1);
+      dest_data = (char *)cmalloc(length + 1);
       memcpy(dest_data, src_data, length);
       dest_data[length] = 0;
 
@@ -137,3 +137,8 @@ char *get_clipboard_buffer(void)
   CFRelease(clipboard);
   return dest_data;
 }
+
+void free_clipboard_buffer(char *buffer)
+{
+  free(buffer);
+}

src/editor/clipboard_cocoa.m

@@ -115,7 +115,7 @@ void copy_buffer_to_clipboard(char **buffer, int lines, int total_length)
     goto err;
 
   size_t buf_len = [chrdata length];
-  char *buf = cmalloc(buf_len + 1);
+  char *buf = (char *)cmalloc(buf_len + 1);
 
   [chrdata getBytes:buf length:buf_len];
   buf[buf_len] = '\0';
@@ -126,3 +126,8 @@ void copy_buffer_to_clipboard(char **buffer, int lines, int total_length)
   [pool release];
   return NULL;
 }
+
+void free_clipboard_buffer(char *buffer)
+{
+  free(buffer);
+}

src/editor/clipboard_null.c

@@ -18,10 +18,16 @@
  */
 
 #include "clipboard.h"
+#include <stdlib.h>
 
 void copy_buffer_to_clipboard(char **buffer, int lines, int total_length) {}
 
 char *get_clipboard_buffer(void)
 {
   return NULL;
 }
+
+void free_clipboard_buffer(char *buffer)
+{
+  free(buffer);
+}

src/editor/clipboard_sdl2.c

@@ -58,3 +58,8 @@ char *get_clipboard_buffer(void)
 {
   return SDL_GetClipboardText();
 }
+
+void free_clipboard_buffer(char *buffer)
+{
+  SDL_free(buffer);
+}

src/editor/clipboard_win32.c

@@ -86,7 +86,7 @@ char *get_clipboard_buffer(void)
     // CF_TEXT is guaranteed to be null-terminated.
     length = strlen(src_data);
 
-    dest_data = cmalloc(length + 1);
+    dest_data = (char *)cmalloc(length + 1);
     strcpy(dest_data, src_data);
 
     GlobalUnlock(global_memory);
@@ -97,3 +97,8 @@ char *get_clipboard_buffer(void)
 
   return NULL;
 }
+
+void free_clipboard_buffer(char *buffer)
+{
+  free(buffer);
+}

src/editor/clipboard_x11.c

@@ -202,3 +202,8 @@ char *get_clipboard_buffer(void)
   XUnlockDisplay(display);
   return dest_data;
 }
+
+void free_clipboard_buffer(char *buffer)
+{
+  free(buffer);
+}

src/editor/robo_ed.c

@@ -1537,7 +1537,8 @@ static void paste_buffer(struct robot_editor_context *rstate)
 #endif
     }
 
-    free(ext_buffer);
+    /* This may need SDL_free if it was allocated by SDL. */
+    free_clipboard_buffer(ext_buffer);
   }
   else