Stops objects from leaking into the void by marking them as free if they existed prior to the loading #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Resources_To_DArray_455430 so the heap compactor can free them again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should grant the player the ability to play through the entire game in 1 sitting(allegedly, I am not good enough at the game to perform this myself), based monitoring the heap data. No more leaky objects. Also corrects a mistake in refactor.py and updates get_sdl_win32.ps1 to the latest required version.
WARNING: MIGHT (WILL?) BREAK EXISTING PLAYBACKS IN SOME PLACES(seems to be related to the LoadingFile entity)