Apollo4p update asize isize #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardSWheatley
force-pushed
the
apollo4p-update-asize-isize
branch
2 times, most recently
from
b5eb25d to
b476ce5
Compare
swift-tk
reviewed
Nov 28, 2024
swift-tk
reviewed
Nov 29, 2024
| LOG_INST_ERR(cfg->log, "%u, failed to configure device.", __LINE__); | ||
| ret = -EHOSTDOWN; | ||
| goto e_return; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
| data->dev_cfg.cmd_length = hal_dev_cfg.eInstrCfg + 1; | |
| data->dev_cfg.addr_length = hal_dev_cfg.eAddrCfg + 1; | |
| @@ -1047,6 +1063,20 @@ static int mspi_pio_prepare(const struct device *controller, am_hal_mspi_pio_tra | |||
|
|
|||
| data->dev_cfg.addr_length = xfer->addr_length; | |||
There was a problem hiding this comment.
Suggested change
| data->dev_cfg.addr_length = xfer->addr_length; |
| if (ret) { | ||
| LOG_INST_ERR(cfg->log, "%u, failed to configure device.", __LINE__); | ||
| ret = -EHOSTDOWN; | ||
| } |
There was a problem hiding this comment.
Updates to data->hal_dev_cfg.eAddrCfg, data->hal_dev_cfg.eInstrCfg, data->dev_cfg.addr_length and data->dev_cfg.cmd_length should happen here. After hal function had returned successful.
RichardSWheatley
force-pushed
the
apollo4p-update-asize-isize
branch
from
b476ce5 to
5de2a46
Compare
This adds the separate config for ASIZE and ISIZE setting ran clang format on driver Signed-off-by: Richard Wheatley <[email protected]>
Combine the separate mspi memc in CMakeLists Signed-off-by: Richard Wheatley <[email protected]>
RichardSWheatley
force-pushed
the
apollo4p-update-asize-isize
branch
from
5de2a46 to
c2d78e6
Compare
RichardSWheatley
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update some small features from last pull request for mspi