Skip to content

Commit 152a239

Browse files
authored
remove lunr from codebase (github#32432)
1 parent 8c357dc commit 152a239

17 files changed

+57
-1383
lines changed

.github/workflows/dry-run-elasticsearch-indexing.yml

-119
This file was deleted.

.github/workflows/sync-search-elasticsearch.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,7 @@ jobs:
101101
mkdir /tmp/records
102102
npm run sync-search-indices -- \
103103
--language ${{ matrix.language }} \
104-
--out-directory /tmp/records \
105-
--no-compression --no-lunr-index
104+
/tmp/records
106105
107106
ls -lh /tmp/records
108107
@@ -118,7 +117,8 @@ jobs:
118117
VERSION: ${{ github.event.inputs.version }}
119118
run: |
120119
./script/search/index-elasticsearch.js \
121-
--language ${{ matrix.language }} -- /tmp/records
120+
--language ${{ matrix.language }} \
121+
/tmp/records
122122
123123
- name: Check created indexes and aliases
124124
run: |

.github/workflows/sync-search-pr.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ name: Sync search - PR
88
on:
99
pull_request:
1010
paths:
11-
- script/search/parse-page-sections-into-records.js
12-
- script/search/popular-pages.js
11+
- 'script/search/**'
12+
- 'package*.json'
1313
- lib/search/popular-pages.json
1414
# Ultimately, for debugging this workflow itself
1515
- .github/workflows/sync-search-pr.yml
@@ -98,8 +98,7 @@ jobs:
9898
npm run sync-search-indices -- \
9999
--language en \
100100
--version dotcom \
101-
--out-directory /tmp/records \
102-
--no-compression --no-lunr-index
101+
/tmp/records
103102
104103
ls -lh /tmp/records
105104
@@ -111,7 +110,8 @@ jobs:
111110
run: |
112111
./script/search/index-elasticsearch.js \
113112
--language en \
114-
--version dotcom -- /tmp/records
113+
--version dotcom \
114+
/tmp/records
115115
116116
- name: Check created indexes and aliases
117117
run: |

contributing/search.md

-6
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ The Actions workflow progress can be viewed (by GitHub employees) in the [Action
4545

4646
You can manually run the workflow to generate the indexes after you push your changes to `main` to speed up the indexing when needed. It's recommended to do this for only the `free-pro-team@latest` version and the `en` language because running all languages and versions takes about 40 minutes. To run it manually, click "Run workflow" button in the [Actions tab](https://github.com/github/docs-internal/actions/workflows/sync-search-indices.yml). Enter the language and version you'd like to generate the indexes for as inputs to the workflow. By default, all languages and versions are generated.
4747

48-
## Generating search indexes for your local checkout
49-
50-
You can locally generate search indexes, but please do not check them into your local branch because they can get out-of-sync with the `main` branch quickly.
51-
52-
To locally generate the English version of the Dotcom search index locally, run `LANGUAGE=en VERSION=free-pro-team@latest npm run sync-search`. See [Build and sync](#build-and-sync) below for more details. To revert those files run `git checkout lib/search/indexes`.
53-
5448
### Build and sync
5549

5650
To build all the indices (this takes about an hour):

lib/search/compress.js

-24
This file was deleted.

0 commit comments

Comments
 (0)