GH-1101 Do not include connection type in outgoing p2p_address; otherwise type can be set so that trxs are not sent to peer

Author: heifner

plugins/net_plugin/net_plugin.cpp

@@ -4254,13 +4254,15 @@ namespace eosio {
       if(hello.sig == chain::signature_type())
          hello.token = sha256();
       hello.p2p_address = listen_address;
-      if( is_transactions_only_connection() && hello.p2p_address.find(":trx") == std::string::npos ) hello.p2p_address += ":trx";
-      // if we are not accepting transactions tell peer we are blocks only
-      if( is_blocks_only_connection() || !my_impl->p2p_accept_transactions )
-         if (hello.p2p_address.find(":blk") == std::string::npos)
-            hello.p2p_address += ":blk";
-      if( !is_blocks_only_connection() && !my_impl->p2p_accept_transactions ) {
-         peer_dlog( this, "p2p-accept-transactions=false inform peer blocks only connection ${a}", ("a", hello.p2p_address) );
+      if (incoming()) {
+         if( is_transactions_only_connection() && hello.p2p_address.find(":trx") == std::string::npos ) hello.p2p_address += ":trx";
+         // if we are not accepting transactions tell peer we are blocks only
+         if( is_blocks_only_connection() || !my_impl->p2p_accept_transactions )
+            if (hello.p2p_address.find(":blk") == std::string::npos)
+               hello.p2p_address += ":blk";
+         if( !is_blocks_only_connection() && !my_impl->p2p_accept_transactions ) {
+            peer_dlog( this, "p2p-accept-transactions=false inform peer blocks only connection ${a}", ("a", hello.p2p_address) );
+         }
       }
       hello.p2p_address += " - " + hello.node_id.str().substr(0,7);
 #if defined( __APPLE__ )