From 2d5c1a14d12d04e7c109410e3cc3ec90c36b8094 Mon Sep 17 00:00:00 2001
From: antazoey <antyzoa@gmail.com>
Date: Mon, 6 Jan 2025 12:39:16 -0600
Subject: [PATCH] test: tests are stupid

---
 src/ape_ethereum/trace.py      |  3 +--
 tests/functional/test_trace.py | 18 ++++++++++++------
 2 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/src/ape_ethereum/trace.py b/src/ape_ethereum/trace.py
index c0d5e9f3ef..c65c1ea122 100644
--- a/src/ape_ethereum/trace.py
+++ b/src/ape_ethereum/trace.py
@@ -538,8 +538,7 @@ def _discover_calltrace_approach(self) -> CallTreeNode:
             self._set_approach(approach)
             return call
 
-        # Not sure this would happen, as the basic-approach should
-        # always work.
+        # Not sure this happens, as the basic-approach should always work.
         reason_str = ", ".join(f"{k}={v}" for k, v in reason_map.items())
         raise ProviderError(f"Unable to create CallTreeNode. Reason(s): {reason_str}")
 
diff --git a/tests/functional/test_trace.py b/tests/functional/test_trace.py
index 62e16cd32c..193ca717e7 100644
--- a/tests/functional/test_trace.py
+++ b/tests/functional/test_trace.py
@@ -239,14 +239,19 @@ def side_effect(rpc, arguments):
 
 
 def test_transaction_trace_provider_does_not_implement_client_version(
-    mocker, vyper_contract_instance, not_owner, networks
+    mocker, vyper_contract_instance, not_owner, networks, ethereum, chain
 ):
     tx = vyper_contract_instance.setNumber(0, sender=not_owner, raise_on_revert=False)
     mock_weird_node = mocker.MagicMock()
     mock_weird_node.client_version.side_effect = AttributeError
-    provider = networks.provider
-    networks.active_provider = mock_weird_node
-    trace = TransactionTrace.model_validate(
+    mock_weird_node.network = ethereum.local
+
+    class HackyTransactionTrace(TransactionTrace):
+        def _discover_calltrace_approach(self) -> CallTreeNode:
+            # Not needed for test.
+            return None  # type: ignore
+
+    trace = HackyTransactionTrace.model_validate(
         {
             "call_trace_approach": None,
             "debug_trace_transaction_parameters": {"enableMemory": True},
@@ -254,9 +259,10 @@ def test_transaction_trace_provider_does_not_implement_client_version(
             "transaction": tx,
         }
     )
-    actual = trace.get_calltree()
+    provider = networks.provider
+    networks.active_provider = mock_weird_node
+    _ = trace.get_calltree()
     networks.provider = provider
-    assert isinstance(actual, CallTreeNode)
     assert trace.call_trace_approach is not TraceApproach.PARITY