Avoid creating .bzl files in config workspace

Author: revati-naik-apex

repos/config/detail/BUILD.bazel

@@ -30,3 +30,5 @@ py_binary(
     deps = [requirement("pyyaml")],
     visibility = ["//visibility:public"],
 )
+
+exports_files(["generate_ros2_config.py", "lock_repos.py"])

repos/config/detail/generate_repos_lock.bzl

@@ -1,21 +1,18 @@
 load("@python_deps//:requirements.bzl", "requirement")
-load("@ros2_config//:repos_index_file.bzl", "REPOS_INDEX_FILE")
-load("@ros2_config//:repos_overlay_files.bzl", "REPOS_OVERLAY_FILES")
-load("@ros2_config//:repos_setup_file.bzl", "REPOS_SETUP_FILE")
 load("@rules_python//python:defs.bzl", "py_binary")
 
-def generate_repos_lock(name, repos_file, setup_file, overlay_files):
+def generate_repos_lock(*, name, repos_file, setup_file, overlay_files):
     """Macro to create a py_binary for generating repos_lock.update"""
 
     py_binary(
         name = name,
-        srcs = ["lock_repos.py", "generate_ros2_config.py"],
-        main = "lock_repos.py",
-        data = [REPOS_INDEX_FILE, REPOS_SETUP_FILE] + REPOS_OVERLAY_FILES,
+        srcs = [Label("lock_repos.py"), Label("generate_ros2_config.py")],
+        main = Label("lock_repos.py"),
+        data = [repos_file, setup_file] + overlay_files,
         args = [
-            "$(execpath {})".format(REPOS_INDEX_FILE),
-            "$(execpath {})".format(REPOS_SETUP_FILE),
-        ] + ["$(execpath {})".format(f) for f in REPOS_OVERLAY_FILES],
+            "$(execpath {})".format(repos_file),
+            "$(execpath {})".format(setup_file),
+        ] + ["$(execpath {})".format(f) for f in overlay_files],
         deps = [requirement("pyyaml")],
         visibility = ["//visibility:public"],
-    )
+    )

repos/config/detail/ros2_config.bzl

@@ -35,24 +35,28 @@ load("@rules_ros//repos/config/detail:generate_repos_lock.bzl", "generate_repos_
 
 generate_repos_lock(
     name = "repos_lock.update",
-    repos_file = ":repos_index_file.bzl",  # Custom repos file
-    setup_file = ":repos_setup_file.bzl",  # Custom setup file
+    repos_file = "ros.repos",  # Custom repos file
+    setup_file = "setup.bzl",  # Custom setup file
     overlay_files = [
-        ":repos_overlay_files.bzl",
+{overlays}
     ],
 )
 
 exports_files(glob(["**/*"]))
 """
 
-
 def _ros2_config_impl(ctx):
-    ctx.file("repos_index_file.bzl", content = "REPOS_INDEX_FILE = '{}'".format(ctx.attr.repos_index))
-    ctx.file("repos_overlay_files.bzl", content = "REPOS_OVERLAY_FILES = {}".format(["{}".format(i) for i in ctx.attr.repos_index_overlays]))
-    ctx.file("repos_setup_file.bzl", content = "REPOS_SETUP_FILE = '{}'".format(ctx.attr.setup_file))
+    ctx.symlink(ctx.attr.repos_index, "ros.repos")
     ctx.symlink(ctx.attr.setup_file, "setup.bzl")
+    i = 0
+    overlay_files = []
+    for file in ctx.attr.repos_index_overlays:
+        filname = "overlay_{}.bzl".format(i)
+        ctx.symlink(file, filname)
+        i += 1
+        overlay_files.append(filname)
     ctx.file("WORKSPACE", content = "workspace(name = {})".format(ctx.name), executable = False)
-    ctx.file("BUILD.bazel", content = BUILD_FILE_CONTENT, executable = False)
+    ctx.file("BUILD.bazel", content = BUILD_FILE_CONTENT.format(overlays="\n".join(['        "{}",'.format(filename) for filename in overlay_files])), executable = False)
 
     return update_attrs(ctx.attr, _archive_attrs.keys(), {})