Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save, Read and Delete Audio files,and add Audio Visualizer for display #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

crazypoo
Copy link

@crazypoo crazypoo commented Mar 5, 2023

Hello friend,#8 complete,and you can see my demo or project https://github.com/crazypoo/PTChatGPT

@AppDevGuy
Copy link
Owner

Hi @crazypoo thanks for the contribution. I like that you have tackled something I want to implement.

Could you please put some details on the Pull Request like:

  • What it does.
  • Whether you can write some unit tests for the changes it.
  • Do current unit tests still run? (press cmd + shift + U)

I will create a development branch so I can clean it up and contribute a few other things to this. I will also check out your repo. Thanks again.

Copy link
Owner

@AppDevGuy AppDevGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for submitting a pull request. I hope my comments help you improve your work, it's a good start.

I would also like it if instead of recording every time, we use a public variable that allows the developer or user to decide if they want to record every time. We don't want to record and save to the documents directory every single time, as that could result in making their app very big.

I also would like to see a function that deletes recordings too because if we are responsible for saving the recordings, we must also be responsible for enabling them to be deleted.

I hope this helps. Thanks again.

@crazypoo
Copy link
Author

crazypoo commented Mar 6, 2023

ok,i will fix it

crazypoo added 4 commits March 7, 2023 00:21
修復一些昆蟲
1.主要添加删除用户声音的方法/主要添加刪除用戶聲音的方法/Add methods to delete user voice file(s)/Añadir métodos para eliminar el(los) archivo(s) de voz del usuario
2.添加了可以选择候录音的选项/添加了可以選擇錄音的選項/Added the option to wait for recording/Se ha añadido la opción de esperar la grabación
3.修复了一些昆虫/修復了一些昆蟲/Fix some bugs/Corregir algunos errores
Transcription voice file path
@AppDevGuy AppDevGuy changed the title #8 complete Save, Read and Delete Audio files Mar 15, 2023
@crazypoo crazypoo changed the title Save, Read and Delete Audio files Save, Read and Delete Audio files,and add Audio Visualizer for display Mar 21, 2023
@hllGitHub
Copy link

Can this pull request be accepted? I hope I can use this feature, thanks.

@crazypoo
Copy link
Author

crazypoo commented Jan 8, 2024

Can this pull request be accepted? I hope I can use this feature, thanks.

我放在我这里了,以后在我这里更新,https://github.com/crazypoo/PTools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants