Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoints should probably expect POST instead of GET #13

Open
ItsElaineTime opened this issue Jul 30, 2017 · 2 comments
Open

API endpoints should probably expect POST instead of GET #13

ItsElaineTime opened this issue Jul 30, 2017 · 2 comments

Comments

@ItsElaineTime
Copy link
Member

Browsers, especially mobile ones, may re-send GETs because they're not supposed to have side effects.

@djcapelis
Copy link
Member

I don't believe we have anything that causes an undesirable side effect in our API. At worst you might rate a current player the same way you rated a previous one. I think this can be closed?

@ItsElaineTime
Copy link
Member Author

The admin stuff scared me more than the public stuff, especially if the only way to reset the leader board is to hit a URL manually. (I might throw up a button that requires one of those type a phrase to confirm things.)

I've since started pinging the admin endpoints via XHR so it never leaves a history entry, so I'm less worried about this. I wanna call this polish or p3 or whatever for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants