Skip to content

Commit 5df7166

Browse files
committed
Increment @failure_count if build_shared_library fails
1 parent a967a67 commit 5df7166

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Diff for: CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
1717
### Fixed
1818

1919
- Fix missing `LED_BUILTIN` definition for Arduino Due, Zero and Circuit Playground.
20+
- No longer ignore failures if the first step of compiling files for the
21+
unit test fails.
2022

2123
### Security
2224

Diff for: exe/arduino_ci.rb

+3-1
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,9 @@ def perform_unit_tests(cpp_library, file_config)
436436
puts
437437
compilers.each do |gcc_binary|
438438
# before compiling the tests, build a shared library of everything except the test code
439-
next unless build_shared_library(gcc_binary, p, config, cpp_library)
439+
build_result = build_shared_library(gcc_binary, p, config, cpp_library)
440+
@failure_count += 1 unless build_result
441+
next unless build_result
440442

441443
# now build and run each test using the shared library build above
442444
config.allowable_unittest_files(cpp_library.test_files).each do |unittest_path|

0 commit comments

Comments
 (0)