Merge pull request #7 from mickeybeurskens/main

Minor spacing and naming fixes

Author: egges

9 - solid/dependency-inversion-after.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -19,13 +20,14 @@ def total_price(self):
             total += self.quantities[i] * self.prices[i]
         return total
 
+
 class Authorizer(ABC):
     @abstractmethod
     def is_authorized(self) -> bool:
         pass
 
 
-class Authorizer_SMS(Authorizer):
+class AuthorizerSMS(Authorizer):
 
     def __init__(self):
         self.authorized = False
@@ -37,7 +39,8 @@ def verify_code(self, code):
     def is_authorized(self) -> bool:
         return self.authorized
 
-class Authorizer_Google(Authorizer):
+
+class AuthorizerGoogle(Authorizer):
 
     def __init__(self):
         self.authorized = False
@@ -49,7 +52,8 @@ def verify_code(self, code):
     def is_authorized(self) -> bool:
         return self.authorized
 
-class Authorizer_Robot(Authorizer):
+
+class AuthorizerRobot(Authorizer):
 
     def __init__(self):
         self.authorized = False
@@ -73,14 +77,15 @@ class DebitPaymentProcessor(PaymentProcessor):
     def __init__(self, security_code, authorizer: Authorizer):
         self.security_code = security_code
         self.authorizer = authorizer
-    
+
     def pay(self, order):
         if not self.authorizer.is_authorized():
             raise Exception("Not authorized")
         print("Processing debit payment type")
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -91,6 +96,7 @@ def pay(self, order):
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class PaypalPaymentProcessor(PaymentProcessor):
 
     def __init__(self, email_address, authorizer: Authorizer):
@@ -111,8 +117,8 @@ def pay(self, order):
 order.add_item("USB cable", 2, 5)
 
 print(order.total_price())
-authorizer = Authorizer_Robot()
+authorizer = AuthorizerRobot()
 # authorizer.verify_code(465839)
 authorizer.not_a_robot()
 processor = PaypalPaymentProcessor("[email protected]", authorizer)
-processor.pay(order)
+processor.pay(order)

9 - solid/dependency-inversion-before.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -19,6 +20,7 @@ def total_price(self):
             total += self.quantities[i] * self.prices[i]
         return total
 
+
 class SMSAuthorizer:
 
     def __init__(self):
@@ -44,14 +46,15 @@ class DebitPaymentProcessor(PaymentProcessor):
     def __init__(self, security_code, authorizer: SMSAuthorizer):
         self.security_code = security_code
         self.authorizer = authorizer
-    
+
     def pay(self, order):
         if not self.authorizer.is_authorized():
             raise Exception("Not authorized")
         print("Processing debit payment type")
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -62,6 +65,7 @@ def pay(self, order):
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class PaypalPaymentProcessor(PaymentProcessor):
 
     def __init__(self, email_address, authorizer: SMSAuthorizer):
@@ -85,4 +89,4 @@ def pay(self, order):
 authorizer = SMSAuthorizer()
 # authorizer.verify_code(465839)
 processor = PaypalPaymentProcessor("[email protected]", authorizer)
-processor.pay(order)
+processor.pay(order)

9 - solid/interface-segregation-after-comp.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -19,6 +20,7 @@ def total_price(self):
             total += self.quantities[i] * self.prices[i]
         return total
 
+
 class SMSAuthorizer:
 
     def __init__(self):
@@ -44,14 +46,15 @@ class DebitPaymentProcessor(PaymentProcessor):
     def __init__(self, security_code, authorizer: SMSAuthorizer):
         self.security_code = security_code
         self.authorizer = authorizer
-    
+
     def pay(self, order):
         if not self.authorizer.is_authorized():
             raise Exception("Not authorized")
         print("Processing debit payment type")
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -62,6 +65,7 @@ def pay(self, order):
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class PaypalPaymentProcessor(PaymentProcessor):
 
     def __init__(self, email_address, authorizer: SMSAuthorizer):
@@ -85,4 +89,4 @@ def pay(self, order):
 authorizer = SMSAuthorizer()
 # authorizer.verify_code(465839)
 processor = PaypalPaymentProcessor("[email protected]", authorizer)
-processor.pay(order)
+processor.pay(order)

9 - solid/interface-segregation-after.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -26,7 +27,8 @@ class PaymentProcessor(ABC):
     def pay(self, order):
         pass
 
-class PaymentProcessor_SMS(PaymentProcessor):
+
+class PaymentProcessorSMS(PaymentProcessor):
 
     @abstractmethod
     def auth_sms(self, code):
@@ -36,7 +38,8 @@ def auth_sms(self, code):
     def pay(self, order):
         pass
 
-class DebitPaymentProcessor(PaymentProcessor_SMS):
+
+class DebitPaymentProcessor(PaymentProcessorSMS):
 
     def __init__(self, security_code):
         self.security_code = security_code
@@ -45,14 +48,15 @@ def __init__(self, security_code):
     def auth_sms(self, code):
         print(f"Verifying SMS code {code}")
         self.verified = True
-    
+
     def pay(self, order):
         if not self.verified:
             raise Exception("Not authorized")
         print("Processing debit payment type")
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -63,7 +67,8 @@ def pay(self, order):
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
-class PaypalPaymentProcessor(PaymentProcessor_SMS):
+
+class PaypalPaymentProcessor(PaymentProcessorSMS):
 
     def __init__(self, email_address):
         self.email_address = email_address
@@ -89,4 +94,4 @@ def pay(self, order):
 print(order.total_price())
 processor = PaypalPaymentProcessor("[email protected]")
 processor.auth_sms(465839)
-processor.pay(order)
+processor.pay(order)

9 - solid/interface-segregation-before.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -30,6 +31,7 @@ def auth_sms(self, code):
     def pay(self, order):
         pass
 
+
 class DebitPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -39,14 +41,15 @@ def __init__(self, security_code):
     def auth_sms(self, code):
         print(f"Verifying SMS code {code}")
         self.verified = True
-    
+
     def pay(self, order):
         if not self.verified:
             raise Exception("Not authorized")
         print("Processing debit payment type")
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -60,6 +63,7 @@ def pay(self, order):
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class PaypalPaymentProcessor(PaymentProcessor):
 
     def __init__(self, email_address):
@@ -86,4 +90,4 @@ def pay(self, order):
 print(order.total_price())
 processor = DebitPaymentProcessor("2349875")
 processor.auth_sms(465839)
-processor.pay(order)
+processor.pay(order)

9 - solid/liskov-substitution-after.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -26,16 +27,18 @@ class PaymentProcessor(ABC):
     def pay(self, order):
         pass
 
+
 class DebitPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
         self.security_code = security_code
-    
+
     def pay(self, order):
         print("Processing debit payment type")
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
 
     def __init__(self, security_code):
@@ -46,6 +49,7 @@ def pay(self, order):
         print(f"Verifying security code: {self.security_code}")
         order.status = "paid"
 
+
 class PaypalPaymentProcessor(PaymentProcessor):
 
     def __init__(self, email_address):
@@ -64,4 +68,4 @@ def pay(self, order):
 
 print(order.total_price())
 processor = PaypalPaymentProcessor("[email protected]")
-processor.pay(order)
+processor.pay(order)

9 - solid/liskov-substitution-before.py

@@ -1,5 +1,6 @@
 from abc import ABC, abstractmethod
 
+
 class Order:
 
     def __init__(self):
@@ -20,25 +21,27 @@ def total_price(self):
         return total
 
 
-
 class PaymentProcessor(ABC):
 
     @abstractmethod
     def pay(self, order, security_code):
         pass
 
+
 class DebitPaymentProcessor(PaymentProcessor):
     def pay(self, order, security_code):
         print("Processing debit payment type")
         print(f"Verifying security code: {security_code}")
         order.status = "paid"
 
+
 class CreditPaymentProcessor(PaymentProcessor):
     def pay(self, order, security_code):
         print("Processing credit payment type")
         print(f"Verifying security code: {security_code}")
         order.status = "paid"
 
+
 class PaypalPaymentProcessor(PaymentProcessor):
     def pay(self, order, security_code):
         print("Processing paypal payment type")
@@ -53,4 +56,4 @@ def pay(self, order, security_code):
 
 print(order.total_price())
 processor = PaypalPaymentProcessor()
-processor.pay(order, "[email protected]")
+processor.pay(order, "[email protected]")