utilize the utils

Author: serenyadev

common/src/main/java/net/artienia/rubinated_nether/block/LavaLamp.java

@@ -1,6 +1,8 @@
 package net.artienia.rubinated_nether.block;
 
+import net.artienia.rubinated_nether.utils.ShapeUtils;
 import net.minecraft.core.BlockPos;
+import net.minecraft.core.Direction;
 import net.minecraft.world.entity.player.Player;
 import net.minecraft.world.item.ItemStack;
 import net.minecraft.world.level.BlockGetter;
@@ -16,27 +18,18 @@
 import net.minecraft.world.phys.shapes.VoxelShape;
 import org.jetbrains.annotations.Nullable;
 
+import java.util.Map;
+
 public class LavaLamp extends RotatedPillarBlock {
-   protected static final float AABB_MIN = 2.0F;
-   protected static final float AABB_MAX = 14.0F;
-   protected static final VoxelShape Y_AXIS_AABB = Block.box(2.0D, 0.0D, 2.0D, 14.0D, 16.0D, 14.0D);
-   protected static final VoxelShape Z_AXIS_AABB = Block.box(2.0D, 2.0D, 0.0D, 14.0D, 14.0D, 16.0D);
-   protected static final VoxelShape X_AXIS_AABB = Block.box(0.0D, 2.0D, 2.0D, 16.0D, 14.0D, 14.0D);
+
+   protected static final Map<Direction.Axis, VoxelShape> AXIS_SHAPES = ShapeUtils.allAxis(Block.box(2.0D, 0.0D, 2.0D, 14.0D, 16.0D, 14.0D));
 
    public LavaLamp(Properties properties) {
       super(properties);
    }
 
-   public VoxelShape getShape(BlockState p_154346_, BlockGetter p_154347_, BlockPos p_154348_, CollisionContext p_154349_) {
-      switch (p_154346_.getValue(AXIS)) {
-         case X:
-         default:
-            return X_AXIS_AABB;
-         case Z:
-            return Z_AXIS_AABB;
-         case Y:
-            return Y_AXIS_AABB;
-      }
+   public VoxelShape getShape(BlockState state, BlockGetter view, BlockPos pos, CollisionContext context) {
+      return AXIS_SHAPES.get(state.getValue(AXIS));
    }
 
    public void playerDestroy(Level level, Player player, BlockPos pos, BlockState state, @Nullable BlockEntity blockEntity, ItemStack tool) {

common/src/main/java/net/artienia/rubinated_nether/utils/ShapeUtils.java

@@ -16,13 +16,19 @@
  */
 public class ShapeUtils {
 
+    public static Map<Direction.Axis, VoxelShape> allAxis(VoxelShape facingY) {
+        Map<Direction.Axis, VoxelShape> map = new EnumMap<>(Direction.Axis.class);
+        for(Direction.Axis axis : Direction.Axis.values()) {
+            Vec3 dir = getDirectionRotationVec(Direction.fromAxisAndDirection(axis, Direction.AxisDirection.POSITIVE));
+            map.put(axis, rotatedCopy(facingY, dir));
+        }
+        return map;
+    }
+
     public static Map<Direction, VoxelShape> allDirections(VoxelShape facingUp) {
         Map<Direction, VoxelShape> map = new EnumMap<>(Direction.class);
         for(Direction direction : Direction.values()) {
-            Vec3 dir = new Vec3(
-                direction == Direction.UP ? 0 : (Direction.Plane.VERTICAL.test(direction) ? 180 : 90),
-                -((Math.max(direction.get2DDataValue(), 0) & 3) * 90f), 0
-            );
+            Vec3 dir = getDirectionRotationVec(direction);
             map.put(direction, rotatedCopy(facingUp, dir));
         }
         return map;
@@ -90,4 +96,11 @@ public static Vec3 rotateVec(Vec3 vec, double deg, Direction.Axis axis) {
     public static double length(VoxelShape shape, Direction.Axis axis) {
         return shape.isEmpty() ? 0 : shape.max(axis) - shape.min(axis);
     }
+
+    private static Vec3 getDirectionRotationVec(Direction direction) {
+        return new Vec3(
+            direction == Direction.UP ? 0 : (Direction.Plane.VERTICAL.test(direction) ? 180 : 90),
+            -((Math.max(direction.get2DDataValue(), 0) & 3) * 90f), 0
+        );
+    }
 }