Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] thinkfan nv_thermal compatibility #178

Closed
Nitrooo opened this issue Nov 21, 2019 · 1 comment
Closed

[Request] thinkfan nv_thermal compatibility #178

Nitrooo opened this issue Nov 21, 2019 · 1 comment

Comments

@Nitrooo
Copy link

Nitrooo commented Nov 21, 2019

I use thinkfan on my ThinkPad. You can configure it to read the NVIDIA GPU temperature using the nv_thermal entry in its config file. The problem is that optimus-manager doesn't work properly with that configuration because it can't unload the nvidia module when thinkfan is running in that mode. I would need two scripts like /etc/optimus-manager/nvidia-enable.sh and /etc/optimus-manager/nvidia-disable.sh, but prior to disabling and after enabling the nvidia module (switch from/to nvidia AND hybrid), to reload thinkfan with the proper configuration (with or without the nv_thermal entry).

Can you add such additional scripts? What could I do otherwise?

@nwildner
Copy link
Collaborator

nwildner commented Jul 2, 2024

Hello @Nitrooo .

While we would love to see a feature that would integrate thinkfan with optimus-manager but I think this would be better suited for thinkfan to deal with, and not "hold" the module making the unload operation to fail, the same way there is a issue on that repo to deal with the fact hosts can miss one GPU that is being pci disabled for power

Also, this case is really a corner-case for optimus-manager and it will require someone with a Thinkpad laptop to develop it so, while this community is open for pull requests that would implement those nvidia module load/unload hooks, we'll keep this case closed until someone comes with a PR to implement this.

We suggest you to also open a case on thinkfan repo for them to create a mechanism that nv_thermal will not hold module unload and deal with the fact that this module might be missing, specially on laptop environments.

Have a nice week ahead.

@nwildner nwildner closed this as completed Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants