Clean up NettyBody ContenType override

Author: slandelle

client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java

@@ -84,13 +84,8 @@ private NettyBody body(Request request) {
             nettyBody = new NettyInputStreamBody(request.getStreamData());
 
         } else if (isNonEmpty(request.getFormParams())) {
-
-            CharSequence contentType = null;
-            if (!request.getHeaders().contains(CONTENT_TYPE)) {
-                contentType = HttpHeaderValues.APPLICATION_X_WWW_FORM_URLENCODED;
-            }
-
-            nettyBody = new NettyByteBufferBody(urlEncodeFormParams(request.getFormParams(), bodyCharset), contentType);
+            CharSequence contentTypeOverride = request.getHeaders().contains(CONTENT_TYPE) ? null : HttpHeaderValues.APPLICATION_X_WWW_FORM_URLENCODED;
+            nettyBody = new NettyByteBufferBody(urlEncodeFormParams(request.getFormParams(), bodyCharset), contentTypeOverride);
 
         } else if (isNonEmpty(request.getBodyParts())) {
             nettyBody = new NettyMultipartBody(request.getBodyParts(), request.getHeaders(), config);
@@ -188,8 +183,8 @@ public NettyRequest newNettyRequest(Request request, boolean forceConnect, Proxy
                 headers.set(CONTENT_LENGTH, body.getContentLength());
             }
 
-            if (body.getContentType() != null) {
-                headers.set(CONTENT_TYPE, body.getContentType());
+            if (body.getContentTypeOverride() != null) {
+                headers.set(CONTENT_TYPE, body.getContentTypeOverride());
             }
         }
 

client/src/main/java/org/asynchttpclient/netty/request/body/NettyBody.java

@@ -23,7 +23,9 @@ public interface NettyBody {
 
     long getContentLength();
 
-    CharSequence getContentType();
+    default CharSequence getContentTypeOverride() {
+        return null;
+    }
 
     void write(Channel channel, NettyResponseFuture<?> future) throws IOException;
 }

client/src/main/java/org/asynchttpclient/netty/request/body/NettyBodyBody.java

@@ -51,11 +51,6 @@ public long getContentLength() {
         return body.getContentLength();
     }
 
-    @Override
-    public String getContentType() {
-        return null;
-    }
-
     @Override
     public void write(final Channel channel, NettyResponseFuture<?> future) throws IOException {
 

client/src/main/java/org/asynchttpclient/netty/request/body/NettyByteArrayBody.java

@@ -20,27 +20,16 @@
 public class NettyByteArrayBody extends NettyDirectBody {
 
     private final byte[] bytes;
-    private final String contentType;
 
     public NettyByteArrayBody(byte[] bytes) {
-        this(bytes, null);
-    }
-
-    public NettyByteArrayBody(byte[] bytes, String contentType) {
         this.bytes = bytes;
-        this.contentType = contentType;
     }
 
     @Override
     public long getContentLength() {
         return bytes.length;
     }
 
-    @Override
-    public String getContentType() {
-        return contentType;
-    }
-
     @Override
     public ByteBuf byteBuf() {
         return Unpooled.wrappedBuffer(bytes);

client/src/main/java/org/asynchttpclient/netty/request/body/NettyByteBufferBody.java

@@ -21,18 +21,18 @@
 public class NettyByteBufferBody extends NettyDirectBody {
 
     private final ByteBuffer bb;
-    private final CharSequence contentType;
+    private final CharSequence contentTypeOverride;
     private final long length;
 
     public NettyByteBufferBody(ByteBuffer bb) {
         this(bb, null);
     }
 
-    public NettyByteBufferBody(ByteBuffer bb, CharSequence contentType) {
+    public NettyByteBufferBody(ByteBuffer bb, CharSequence contentTypeOverride) {
         this.bb = bb;
         length = bb.remaining();
         bb.mark();
-        this.contentType = contentType;
+        this.contentTypeOverride = contentTypeOverride;
     }
 
     @Override
@@ -41,8 +41,8 @@ public long getContentLength() {
     }
 
     @Override
-    public CharSequence getContentType() {
-        return contentType;
+    public CharSequence getContentTypeOverride() {
+        return contentTypeOverride;
     }
 
     @Override

client/src/main/java/org/asynchttpclient/netty/request/body/NettyCompositeByteArrayBody.java

@@ -21,17 +21,11 @@
 public class NettyCompositeByteArrayBody extends NettyDirectBody {
 
     private final byte[][] bytes;
-    private final String contentType;
     private final long contentLength;
 
     public NettyCompositeByteArrayBody(List<byte[]> bytes) {
-        this(bytes, null);
-    }
-
-    public NettyCompositeByteArrayBody(List<byte[]> bytes, String contentType) {
         this.bytes = new byte[bytes.size()][];
         bytes.toArray(this.bytes);
-        this.contentType = contentType;
         long l = 0;
         for (byte[] b : bytes)
             l += b.length;
@@ -43,11 +37,6 @@ public long getContentLength() {
         return contentLength;
     }
 
-    @Override
-    public String getContentType() {
-        return contentType;
-    }
-
     @Override
     public ByteBuf byteBuf() {
         return Unpooled.wrappedBuffer(bytes);

client/src/main/java/org/asynchttpclient/netty/request/body/NettyFileBody.java

@@ -62,11 +62,6 @@ public long getContentLength() {
         return length;
     }
 
-    @Override
-    public String getContentType() {
-        return null;
-    }
-
     @Override
     public void write(Channel channel, NettyResponseFuture<?> future) throws IOException {
         @SuppressWarnings("resource")

client/src/main/java/org/asynchttpclient/netty/request/body/NettyInputStreamBody.java

@@ -53,11 +53,6 @@ public long getContentLength() {
         return contentLength;
     }
 
-    @Override
-    public String getContentType() {
-        return null;
-    }
-
     @Override
     public void write(Channel channel, NettyResponseFuture<?> future) throws IOException {
         final InputStream is = inputStream;

client/src/main/java/org/asynchttpclient/netty/request/body/NettyMultipartBody.java

@@ -24,19 +24,19 @@
 
 public class NettyMultipartBody extends NettyBodyBody {
 
-    private final String contentType;
+    private final String contentTypeOverride;
 
     public NettyMultipartBody(List<Part> parts, HttpHeaders headers, AsyncHttpClientConfig config) {
         this(newMultipartBody(parts, headers), config);
     }
 
     private NettyMultipartBody(MultipartBody body, AsyncHttpClientConfig config) {
         super(body, config);
-        contentType = body.getContentType();
+        contentTypeOverride = body.getContentType();
     }
 
     @Override
-    public String getContentType() {
-        return contentType;
+    public String getContentTypeOverride() {
+        return contentTypeOverride;
     }
 }

client/src/main/java/org/asynchttpclient/netty/request/body/NettyReactiveStreamsBody.java

@@ -49,11 +49,6 @@ public long getContentLength() {
         return contentLength;
     }
 
-    @Override
-    public String getContentType() {
-        return null;
-    }
-
     @Override
     public void write(Channel channel, NettyResponseFuture<?> future) throws IOException {
         if (future.isStreamConsumed()) {