Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Vending machines and airolcks will repeatedly shock you and can shock you from range. #18219

Closed
1 task done
sadkermit opened this issue Jan 15, 2024 · 5 comments
Closed
1 task done

[Bug]: Vending machines and airolcks will repeatedly shock you and can shock you from range. #18219

sadkermit opened this issue Jan 15, 2024 · 5 comments

Comments

@sadkermit
Copy link
Contributor

Checks

  • I have searched the bug with a few keywords, and I confirm this bug was not yet reported.

Location

Horizon

Describe the issue

Triggering the electrocution state of a vending machine will not just shock you once, but will repeatedly shock you regardless of whether you click the vending machine multiple times. Walking away from the vending machine while it shocks you achieves nothing as it will continue to shock you from range.

First noticed the issue 2-3 weeks ago though never saved the round ID.

How to reproduce

Forget to wear insulated gloves.
Open up a vending machine with a screwdriver.
Snip each wire until you find the one which shocks you.
Walk away from the vending machine while you are getting shocked.

Round ID

crM-b2s4

Staff ckey

No response
@Somguy2
Copy link

Somguy2 commented Mar 14, 2024

This is still an issue. It also happens with doors.
Literally a single mistake rn will force you into crit, and likely kill you without adminheal or medical staff aware of what is happening.

Needs to be fixed. PLS.

@sadkermit sadkermit changed the title [Bug]: Vending machines will repeatedly shock you and can shock you from range. [Bug]: Vending machines and airolcks will repeatedly shock you and can shock you from range. Mar 14, 2024
@hollyhocc
Copy link
Contributor

still a BAD issue

@HanSolo1519
Copy link
Contributor

STIIILL a bad issue
#19755

@HanSolo1519 HanSolo1519 mentioned this issue Aug 5, 2024
Closed
1 task
@chaoticidealism
Copy link

Still happening. My character just got both hands vaporized trying to hack into a first-aid vendor. Oh, the irony.

This was referenced Jan 2, 2025
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 4, 2025
@victorShchagin
Fix devices shocking players repeatedly (#20325)
50d3341 
A fix for #18219

Thanks to mattatlas for figuring out the actual cause -
`/datum/wires/suit_storage_unit/interactable` proc was called every tick
when TGUI window for that element was opened, and it had code that
checked for `isElectrified()`, leading to repeated shocks.

Removal should resolve the issue, actual .shock() calls are happening
when appropriate - in `/datum/wires/<MACHINE>/on_pulse(wire)` when
interacting with wiring, or in `<MACHINE>.dm` itself when processing
interactions.
 
Could not do full testing due to a lack of experience with the game and
tooling, but no issues were encountered with what was done.

---------

Co-authored-by: color <color@WINEWEASEL>
@victorShchagin
Copy link
Contributor

#20325 was merged, should be all fixed now. Unless it blows up in some new and exciting fashion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@chaoticidealism @NonQueueingMatt @hollyhocc @sadkermit @HanSolo1519 @Somguy2 @victorShchagin