Fix: Fix blank space in LargeProfile without description (#211)

* Make LargeProfile responsive when the description is empty

* Update the Profile code when the description is empty

* Record the updated screenshot base line

* Add back the deprecated annotation to the preview composable

* Record the updated screenshot base line

Author: AdamGrzybkowski

gravatar-ui/screenshotTests/roborazzi/com.gravatar.gravatar.ui.components.LargeProfileTest.legacyProfileWithoutDescription.png

@@ -189,6 +189,41 @@ private fun LargeProfilePreview() {
     )
 }
 
+@Preview(showBackground = true)
+@Composable
+private fun LargeProfileWithoutDescriptionPreview() {
+    LargeProfile(
+        defaultProfile(
+            hash = "1234567890",
+            displayName = "Dominique Doe",
+            jobTitle = "Farmer",
+            company = "Farmers United",
+            location = "Crac'h, France",
+            pronouns = "They/Them",
+            verifiedAccounts = listOf(
+                VerifiedAccount {
+                    serviceType = "mastodon"
+                    serviceLabel = "Mastodon"
+                    serviceIcon = URI("https://example.com")
+                    url = URI("https://mastodon.social/@ddoe")
+                },
+                VerifiedAccount {
+                    serviceType = "tumblr"
+                    serviceLabel = "Tumblr"
+                    serviceIcon = URI("https://example.com")
+                    url = URI("https://ddoe.tumblr.com")
+                },
+                VerifiedAccount {
+                    serviceType = "wordpress"
+                    serviceLabel = "WordPress"
+                    serviceIcon = URI("https://example.com")
+                    url = URI("https://ddoe.wordpress.com")
+                },
+            ),
+        ),
+    )
+}
+
 // TODO Make this preview internal in a future major release
 @Deprecated(
     "This function is deprecated and will be removed in a future release.",

gravatar-ui/screenshotTests/roborazzi/com.gravatar.gravatar.ui.components.LargeProfileTest.profileWithoutDescription.png

@@ -92,10 +92,11 @@ public fun Profile(
                             )
                         }
                     }
-                    if (state.isAboutMeVisible()) {
-                        Spacer(modifier = Modifier.height(16.dp))
-                        AboutMe(state = state, skeletonModifier = Modifier.fillMaxWidth(0.8f))
-                    }
+                    AboutMe(
+                        state = state,
+                        modifier = Modifier.padding(top = 16.dp),
+                        skeletonModifier = Modifier.padding(top = 16.dp).fillMaxWidth(0.8f),
+                    )
                     Spacer(modifier = Modifier.height(4.dp))
                     Row(
                         modifier = Modifier.fillMaxWidth(),
@@ -149,9 +150,6 @@ public fun Profile(state: ComponentState<LegacyProfile>, modifier: Modifier = Mo
     Profile(state = state.toApi2ComponentStateProfile(), modifier = modifier)
 }
 
-private fun ComponentState<Profile>.isAboutMeVisible(): Boolean =
-    this is ComponentState.Loaded && loadedValue.description.isNotEmpty() || this is ComponentState.Loading
-
 @Preview
 @Composable
 private fun ProfilePreview() {

gravatar-ui/src/main/java/com/gravatar/ui/components/LargeProfile.kt

@@ -85,7 +85,9 @@ public fun AboutMe(
         }
 
         is ComponentState.Loaded -> {
-            AboutMe(state.loadedValue, modifier, textStyle, content)
+            if (state.loadedValue.description.isNotBlank()) {
+                AboutMe(state.loadedValue, modifier, textStyle, content)
+            }
         }
 
         ComponentState.Empty -> {