Use single quotes on other tests too

For consistency and to make it easier to understand the special characters we are playing with without having to escape them in double-quote contexts

Author: AliSoftware

tests/pr_changed_files/test_any_match_patterns.sh

@@ -17,41 +17,45 @@ export BUILDKITE_PULL_REQUEST_BASE_BRANCH="base"
 # Initialize the repository
 init_test_repo "$repo_path"
 
-# Create test files
+# Create test files (using single quotes to avoid special chars being interpreted by the shell)
 mkdir -p docs src/swift src/ruby
-echo "doc" > "docs/read me.md"
-echo "doc" > "docs/special\!\@\#\$chars.md"
-echo "swift" > src/swift/main.swift
-echo "ruby" > src/ruby/main.rb
+echo "doc" > 'docs/read me.md'
+echo "doc" > 'docs/special!@*#$chars.md'
+echo "swift" > 'src/swift/main.swift'
+echo "ruby" > 'src/ruby/main.rb'
 git add .
 git commit -m "Add test files"
 
 # [Test] Match specific extension
-result=$(pr_changed_files --any-match "*.swift")
+result=$(pr_changed_files --any-match '*.swift')
 assert_output "true" "$result" "Should match .swift files"
 
 # [Test] Match multiple patterns
-result=$(pr_changed_files --any-match "docs/*.md" "*.rb")
+result=$(pr_changed_files --any-match 'docs/*.md' '*.rb')
 assert_output "true" "$result" "Should match multiple patterns"
 
 # [Test] Match files with spaces and special characters
-result=$(pr_changed_files --any-match "docs/read me.md" "docs/special\!\@\#\$chars.md")
+result=$(pr_changed_files --any-match 'docs/read me.md' 'docs/special!@\*#$chars.md')
 assert_output "true" "$result" "Should match files with spaces and special characters"
 
+# [Test] Match files with spaces and special characters, even when using globbing
+result=$(pr_changed_files --any-match 'docs/read me.md' 'docs/special*chars.md')
+assert_output "true" "$result" "Should match files with spaces and special characters, even when using globbing"
+
 # [Test] No matches
-result=$(pr_changed_files --any-match "*.js")
+result=$(pr_changed_files --any-match '*.js')
 assert_output "false" "$result" "Should not match non-existent patterns"
 
 # [Test] Directory pattern
-result=$(pr_changed_files --any-match "docs/*")
+result=$(pr_changed_files --any-match 'docs/*')
 assert_output "true" "$result" "Should match directory patterns"
 
 # [Test] Exact pattern matching
 echo "swiftfile" > swiftfile.txt
 git add swiftfile.txt
 git commit -m "Add file with swift in name"
 
-result=$(pr_changed_files --any-match "*.swift")
+result=$(pr_changed_files --any-match '*.swift')
 assert_output "true" "$result" "Should only match exact patterns"
 
 echo "✅ Any-match pattern tests passed"

tests/pr_changed_files/test_edge_cases.sh

@@ -41,20 +41,20 @@ output=$(pr_changed_files --any-match "*.txt" --all-match "*.md" 2>&1 || true)
 assert_output "Error: either specify --all-match or --any-match; cannot specify both" "$output" "Should fail with correct error when using mutually exclusive options"
 
 # [Test] Files with spaces and special characters
-mkdir -p "folder with spaces/nested\!\@\#\$folder"
-echo "test" > "folder with spaces/file with spaces.txt"
-echo "test" > "folder with spaces/nested\!\@\#\$folder/file_with_\!\@\#.txt"
+mkdir -p 'folder with spaces/nested!\@*#$folder'
+echo "test" > 'folder with spaces/file with spaces.txt'
+echo "test" > 'folder with spaces/nested!\@*#$folder/file_with_!@*#$chars.txt'
 git add .
 git commit -m "Add files with special characters"
 
 result=$(pr_changed_files)
 assert_output "true" "$result" "Should handle files with spaces and special characters"
 
 # [Test] Pattern matching with spaces and special characters
-result=$(pr_changed_files --any-match "*spaces.txt")
+result=$(pr_changed_files --any-match '*spaces.txt')
 assert_output "true" "$result" "Should match files with special characters in path"
 
-result=$(pr_changed_files --all-match "folder with spaces/*")
+result=$(pr_changed_files --all-match 'folder with spaces/*')
 assert_output "true" "$result" "Should handle directory patterns with spaces"
 
 # [Test] No changes between branches