Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boost: Add notice if legacy concatenation files are used #41604

Draft
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Draft

Boost: Add notice if legacy concatenation files are used #41604

wants to merge 4 commits into from
+63 −0

Conversation

donnchawp
Copy link
Contributor

@donnchawp donnchawp commented Feb 6, 2025 •
edited
Loading

Fixes 41675.

If the new static cache files introduced in #41056 are not being used by a server then notify the user so they can fix the problem.
TODO: link to documentation. Make the notice pretty.

Proposed changes:

  • Add a notice in the CSS and JS concatenation modules. (duplication? Maybe it should be a single notice?)
  • Add a useStaticMinification hook to fetch the static cache files status
  • Register a new readonly status to read the static_minification site option as a bool.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

pc9hqz-3kc-p2

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Apply PR and jetpack rebuild plugins/boost to build everything.
  • Make sure one or both Concatenation modules are enabled. If it's using the new static files you won't see a notice.
  • Create wp-content/.htaccess with RewriteEngine Off in it.
  • A notice should appear in both modules if they are enabled.

@donnchawp donnchawp added [Status] In Progress [Plugin] Boost A feature to speed up the site and improve performance. labels Feb 6, 2025
@donnchawp donnchawp added this to the boost/next milestone Feb 6, 2025
@donnchawp donnchawp self-assigned this Feb 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Boost plugin:

  • Next scheduled release: February 11, 2025.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@donnchawp donnchawp added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Feb 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/assets/src/js/pages/index/index.tsx 0/23 (0.00%) 0.00% 8 💔
projects/plugins/boost/wp-js-data-sync.php 0/283 (0.00%) 0.00% 6 💔

1 file is newly checked for coverage.

File Coverage
projects/plugins/boost/app/assets/src/js/lib/stores/static-minification.ts 0/3 (0.00%) 💔

Full summary · PHP report · JS report

@haqadn haqadn removed this from the boost/3.9.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@donnchawp donnchawp

Labels
[Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boost: Add notice for concat modules if legacy serving is used
2 participants
@donnchawp @haqadn