Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests all and atomic workflows #10277

Merged
merged 46 commits into from
Feb 3, 2025
Merged

Update e2e tests all and atomic workflows #10277

merged 46 commits into from
Feb 3, 2025

Conversation

allie500
Copy link
Contributor

@allie500 allie500 commented Jan 30, 2025 •
edited
Loading

Fixes #10238 #10239

Changes proposed in this Pull Request

  • This PR updates the E2E NPM script that is run inside of .github/actions/e2e/run-log-tests/action.yml
  • It also makes changes to Github workflow files to make sure we install the Playwright Chromium browser before starting the tests.
  • This PR also updates the structure of the e2e test files so that they run in the same groups as the Puppeteer files did.
  • Lastly, the PR also makes changes to various tests to ensure they are passing when run with WooCommerce latest and version 7.7.0.

Testing instructions

  • Github workflow tests should be passing when triggered using this branch.
  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@botwoo
Copy link
Collaborator

botwoo commented Jan 30, 2025 •
edited
Loading

Test the build

Option 1. Jetpack Beta

  • Install and activate Jetpack Beta.
  • Use this build by searching for PR number 10277 or branch name dev/10238-update-e2e-tests-all-workflow in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

  • Latest commit: a6a9c96
  • Build time: 2025-02-03 20:37:23 UTC

Note: the build is updated when a new commit is pushed to this PR.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 30, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 1.37 MB

ℹ️ View Unchanged
Filename Size
release/woocommerce-payments/assets/css/admin.css 1.37 kB
release/woocommerce-payments/assets/css/admin.rtl.css 1.37 kB
release/woocommerce-payments/assets/css/success.css 182 B
release/woocommerce-payments/assets/css/success.rtl.css 184 B
release/woocommerce-payments/dist/blocks-checkout-rtl.css 2.64 kB
release/woocommerce-payments/dist/blocks-checkout.css 2.64 kB
release/woocommerce-payments/dist/blocks-checkout.js 55.7 kB
release/woocommerce-payments/dist/cart-block.js 17.2 kB
release/woocommerce-payments/dist/cart.js 5.73 kB
release/woocommerce-payments/dist/checkout-rtl.css 1.13 kB
release/woocommerce-payments/dist/checkout.css 1.13 kB
release/woocommerce-payments/dist/checkout.js 33.6 kB
release/woocommerce-payments/dist/express-checkout-rtl.css 229 B
release/woocommerce-payments/dist/express-checkout.css 229 B
release/woocommerce-payments/dist/express-checkout.js 15.7 kB
release/woocommerce-payments/dist/frontend-tracks.js 854 B
release/woocommerce-payments/dist/index-rtl.css 39.9 kB
release/woocommerce-payments/dist/index.css 39.9 kB
release/woocommerce-payments/dist/index.js 302 kB
release/woocommerce-payments/dist/multi-currency-analytics.js 1.08 kB
release/woocommerce-payments/dist/multi-currency-rtl.css 4.47 kB
release/woocommerce-payments/dist/multi-currency-switcher-block.js 61.1 kB
release/woocommerce-payments/dist/multi-currency.css 4.47 kB
release/woocommerce-payments/dist/multi-currency.js 57.8 kB
release/woocommerce-payments/dist/order-rtl.css 730 B
release/woocommerce-payments/dist/order.css 730 B
release/woocommerce-payments/dist/order.js 42.5 kB
release/woocommerce-payments/dist/payment-gateways-rtl.css 1.33 kB
release/woocommerce-payments/dist/payment-gateways.css 1.33 kB
release/woocommerce-payments/dist/payment-gateways.js 38.9 kB
release/woocommerce-payments/dist/plugins-page-rtl.css 386 B
release/woocommerce-payments/dist/plugins-page.css 386 B
release/woocommerce-payments/dist/plugins-page.js 20.1 kB
release/woocommerce-payments/dist/product-details-rtl.css 433 B
release/woocommerce-payments/dist/product-details.css 436 B
release/woocommerce-payments/dist/product-details.js 12.5 kB
release/woocommerce-payments/dist/settings-rtl.css 11.6 kB
release/woocommerce-payments/dist/settings.css 11.5 kB
release/woocommerce-payments/dist/settings.js 224 kB
release/woocommerce-payments/dist/subscription-edit-page.js 703 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css 524 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal.css 524 B
release/woocommerce-payments/dist/subscription-product-onboarding-modal.js 20.2 kB
release/woocommerce-payments/dist/subscription-product-onboarding-toast.js 730 B
release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css 120 B
release/woocommerce-payments/dist/subscriptions-empty-state.css 120 B
release/woocommerce-payments/dist/subscriptions-empty-state.js 19.3 kB
release/woocommerce-payments/dist/tokenized-express-checkout-rtl.css 229 B
release/woocommerce-payments/dist/tokenized-express-checkout.css 229 B
release/woocommerce-payments/dist/tokenized-express-checkout.js 16.6 kB
release/woocommerce-payments/dist/tos-rtl.css 235 B
release/woocommerce-payments/dist/tos.css 235 B
release/woocommerce-payments/dist/tos.js 21.8 kB
release/woocommerce-payments/dist/woopay-direct-checkout.js 6.13 kB
release/woocommerce-payments/dist/woopay-express-button.js 25 kB
release/woocommerce-payments/dist/woopay-rtl.css 4.31 kB
release/woocommerce-payments/dist/woopay.css 4.28 kB
release/woocommerce-payments/dist/woopay.js 71 kB
release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css 625 B
release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js 814 B
release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js 2.46 kB
release/woocommerce-payments/vendor/automattic/jetpack-assets/build/jetpack-script-data.js 772 B
release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js 1.02 kB
release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/script-data.js 69 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/babel.config.js 163 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/identity-crisis.css 2.47 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/identity-crisis.js 14.2 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/identity-crisis.rtl.css 2.47 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-connection.css 10 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-connection.js 28.4 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-connection.rtl.css 10 kB
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.css 198 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.js 280 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.rtl.css 198 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.css 625 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.js 333 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.rtl.css 626 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-users.js 424 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js 521 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js 585 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.css 215 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.js 521 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.css 721 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.js 412 B
release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-users.js 632 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css 1.04 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css 294 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css 408 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css 3.59 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css 301 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css 746 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css 574 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css 414 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js 543 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js 9.4 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js 6.78 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js 3.84 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js 545 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js 2.52 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js 22.2 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js 11.7 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js 1.29 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js 507 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js 358 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js 428 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js 1.38 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js 782 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js 1.09 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js 1.26 kB
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css 391 B
release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js 3.04 kB

compressed-size-action

@allie500 allie500 mentioned this pull request Jan 30, 2025
Merged
6 tasks
This was linked to issues Jan 31, 2025
Update the E2E Tests All workflow to run with Playwright #10238
Open
Update the E2E Tests on Atomic All workflow to run with Playwright #10239
Open
allie500 and others added 20 commits January 31, 2025 08:43
@allie500
Revert change to pull request workflow file
06d25db
@allie500
Update run-log-tests action
34a2469 
Update Playwright CI reporters config
@allie500
Remove NODE_ENV flag
595071f
@allie500
Add Playwright browser install step
43c2d02
@allie500
Update Playwright config
657a7be
@allie500
Update run-log-tests action
7e8ec50
@allie500
Update E2E_RESULT_FILEPATH
5f628c2 
Update run-log-tests action
@allie500
Update pull request workflow
78c2410
@allie500
Update Playwright config
8760dce
@allie500
Update results file config
01dcc5d
@allie500
Update failed test cound and retry failed tests command
67db114
@allie500
Update Playwright config
aa2eb6b
@allie500
Update Playwright e2e tests directory structure
afe1564
@allie500
Update e2e-test workflow to install Playwright chromium
6df668c
@eduardoumpierre
Update projects to be a simple chromium setup
ebd662f
@eduardoumpierre
Add Playwright test results to artifacts
58a9fb9
@eduardoumpierre
Disable multi-currency before running price checks
a7b3650
@eduardoumpierre
Remove custom timeouts
2494c5f
@eduardoumpierre
Wait for UI to be unblocked to continue test
f6bdc3c
@eduardoumpierre
Fix snapshots folder location
f129a1e
eduardoumpierre and others added 21 commits February 1, 2025 07:34
@eduardoumpierre
Update E2E results file path for tests all workflow
f3002da
@eduardoumpierre
Add step for installing Playwright
b5028d6
@eduardoumpierre
Remove wait for load state
8299654
@eduardoumpierre
Check for HPOS availability before running the sync
db6633f 
It should fallback to COT when HPOS is not available.
@allie500
Fix strict mode violation for WC 7.7.0 test run
270d80d
@eduardoumpierre
Enable the optional company field
da2cd16
@eduardoumpierre
Add fallback to WC 7.7.0
4d78af5
@eduardoumpierre
Merge branch 'dev/10238-update-e2e-tests-all-workflow' of https://git…
48ed1ef 
…hub.com/Automattic/woocommerce-payments into dev/10238-update-e2e-tests-all-workflow
@allie500
Add wooCoreVersion constant
352aebd
@allie500
Add WC version check to goToSubscriptions
9ec962f
@allie500
Update test to work with WC latest & 7.7.0
4443a72
@eduardoumpierre
Update locator selector to work on WC 7.7.0
232ca49
@eduardoumpierre
Merge branch 'dev/10238-update-e2e-tests-all-workflow' of https://git…
55708e7 
…hub.com/Automattic/woocommerce-payments into dev/10238-update-e2e-tests-all-workflow
@allie500
Update goToSubscriptionPage to work with WC latest and 7.7.0
31de689
@allie500
Fix test to work with WC latest & 7.7.0
5caa5c3
@eduardoumpierre
Update price assertions
9cb41aa
@eduardoumpierre
Merge branch 'dev/10238-update-e2e-tests-all-workflow' of https://git…
0cbb0cb 
…hub.com/Automattic/woocommerce-payments into dev/10238-update-e2e-tests-all-workflow
@eduardoumpierre
Add fallback for WC 7.7.0
9189fa6
@eduardoumpierre
Update selectors to work with the latest WC version
e5d366d
@eduardoumpierre
Increase maxDiffPixelRatio for WC 7.7.0
6f5afaf
@allie500
Add changelog
a6a9c96
@allie500 allie500 marked this pull request as ready for review February 3, 2025 20:39
@allie500 allie500 requested a review from a team as a code owner February 3, 2025 20:39
@allie500 allie500 requested a review from a team February 3, 2025 20:40
eduardoumpierre
eduardoumpierre approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@eduardoumpierre eduardoumpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense and the tests are passing. It's good to be merged! 🚢

@allie500 allie500 merged commit 6c98912 into dev/10240-update-npm-scripts Feb 3, 2025
23 checks passed
@allie500 allie500 deleted the dev/10238-update-e2e-tests-all-workflow branch February 3, 2025 20:45
@allie500 allie500 mentioned this pull request Feb 5, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardoumpierre eduardoumpierre eduardoumpierre approved these changes

Assignees
No one assigned
Labels
pr: needs review
Projects
None yet
Milestone
No milestone
3 participants
@allie500 @botwoo @eduardoumpierre