Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to Disable Serving ActivityPub JSON by User Agent #223

Closed
dshanske opened this issue Dec 20, 2022 · 4 comments
Closed

Request to Disable Serving ActivityPub JSON by User Agent #223

dshanske opened this issue Dec 20, 2022 · 4 comments

Comments

@dshanske
Copy link

As there is not an easy fix for #78 and it seems unlikely there would be, requesting optional special casing based on user agent.

https://github.com/aaronpk/XRay/blob/main/controllers/Parse.php#L16

Essentially, in this function, return early if you detect XRay in the User-Agent.

https://github.com/pfefferle/wordpress-activitypub/blob/master/includes/class-activitypub.php#L36

I know technically speaking, @aaronpk 's code is asking for the ActivityPub version, but one side has to special case it.

Or give me an easy way to filter at this point?

@dshanske
Copy link
Author

@pfefferle
Copy link
Member

pfefferle commented Dec 23, 2022

I do not think it is that easy! @aaronpk has added this feature, because it seems to be a nice fallback if no other semantic is available and we can not be sure, that Microformats are available only because of someone installed the Webmention plugin.

@pfefferle
Copy link
Member

If we could deactivate that by default, than I would vote for doing it on the XRay side!

@pfefferle
Copy link
Member

fixed by @aaronpk aaronpk/XRay#101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants