Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Limit popup to existing sites #98199

Closed
1 task
lsl opened this issue Jan 10, 2025 · 2 comments
Closed
1 task

Settings: Limit popup to existing sites #98199

lsl opened this issue Jan 10, 2025 · 2 comments
Labels
[Experiment] AI labels added [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Feature] User Management Tools for managing site users, their roles, and permissions.

Comments

@lsl
Copy link
Contributor

lsl commented Jan 10, 2025

This PR adds more pop ups for more settings screens.

We should limit who sees any of these pop ups to existing sites only. We can use a future blog id to limit which blogs see the popups and have some overlap.

  • Disable educational popups for new sites (code point)

Image

@github-actions github-actions bot added [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Feature] User Management Tools for managing site users, their roles, and permissions. labels Jan 10, 2025
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Site Settings & Tools: The issue relates to settings configurations, specifically limiting who sees popups based on site status.
  • [Feature] JITM: The issue discusses the management of pop-ups, which are Just In Time Messages used for user interaction and guidance.
  • [Feature] User Management: This feature is relevant as limiting popup visibility could impact user management and site onboarding for new sites.

@lsl
Copy link
Contributor Author

lsl commented Feb 7, 2025

I see this has already been done in wpcom-admin-interface.php

@lsl lsl closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature Group] Site Settings & Tools Settings and tools for managing and configuring your site. [Feature] JITM Just In Time Messages - pop-up tips and suggestions that appear on the dashboard and sidebar. [Feature] User Management Tools for managing site users, their roles, and permissions.
Projects
None yet
Development

No branches or pull requests

1 participant