Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Reader: reader and account flows set Reader as the user's default landing page" #99441

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

DustyReagan
Copy link
Member

Reverts #99379

@DustyReagan DustyReagan self-assigned this Feb 7, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~277 bytes removed 📉 [gzipped])

name                  parsed_size           gzip_size
signup                     -614 B  (-0.2%)     -162 B  (-0.2%)
update-design-flow         -569 B  (-0.0%)      -83 B  (-0.0%)
link-in-bio-tld-flow       -569 B  (-0.0%)      -66 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1362 bytes added 📈 [gzipped])

name                                                     parsed_size           gzip_size
async-load-signup-steps-site-picker                           +631 B  (+0.3%)     +214 B  (+0.3%)
async-load-signup-steps-domains                               +631 B  (+0.1%)     +260 B  (+0.1%)
async-load-signup-steps-difm-site-picker                      +631 B  (+0.3%)     +207 B  (+0.3%)
async-load-calypso-blocks-jitm-templates-sidebar-banner       +631 B  (+1.2%)     +227 B  (+1.2%)
async-load-calypso-blocks-jitm-templates-notice               +631 B  (+1.2%)     +228 B  (+1.2%)
async-load-calypso-blocks-jitm-templates-default              +631 B  (+1.2%)     +226 B  (+1.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug revert-99379-add/reader-as-default-page on your sandbox.

@DustyReagan DustyReagan merged commit 875b150 into trunk Feb 7, 2025
14 checks passed
@DustyReagan DustyReagan deleted the revert-99379-add/reader-as-default-page branch February 7, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants