Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(topbar): add new look for application drawer trigger button when triggerGroupShortName is set #282

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

NiklasRamstrom
Copy link
Contributor

@NiklasRamstrom NiklasRamstrom commented Jun 12, 2024

Describe your changes

Update Drawer Trigger button to follow new Look from figma:
https://www.figma.com/design/RqNwSw0bq0sjSXT6M5uJGQ/My-Systems---Releases?node-id=2440-5383&m=dev

Will only be used when the property "triggerGroupShortName" is set in ApplicationDrawerContent.
If unset, the look will be unchanged.

Old look:
image
image

New Look:
image
image

Checklist before requesting a review

  • I have performed a self-review of my own code
  • I have verified that the code builds perfectly fine on my local system
  • I have added tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have verified that my code follows the style already available in the repository
  • I have made corresponding changes to the documentation

@NiklasRamstrom NiklasRamstrom requested a review from a team as a code owner June 12, 2024 15:05
@NiklasRamstrom NiklasRamstrom enabled auto-merge (squash) June 12, 2024 16:45
Copy link
Contributor

@axis-d0op axis-d0op left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NiklasRamstrom NiklasRamstrom merged commit c2ed8cb into main Jun 13, 2024
4 checks passed
@NiklasRamstrom NiklasRamstrom deleted the niklasra/drawer-updates branch June 13, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants