-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(slider): add section labels support #288
feat(slider): add section labels support #288
Conversation
1801cb1
to
3d7db36
Compare
7b6f4ac
to
268fc33
Compare
6e9b6d6
to
36f048f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks nice. Some changes required though. I defer to other maintainers whether or not changes such as changeset.js/ts should be included or not. They are good changes but have nothing to do with the PR.
1a73dbe
to
2271f65
Compare
bbbd2e2
to
77f3f24
Compare
77f3f24
to
630939a
Compare
The range slider doesn't seems to work that well with sections. The track goes out of bounds. Also the mark label highlighting doesn't work properly when multiple marks have values that equal them. |
630939a
to
6b9381c
Compare
061bd41
to
3309ca6
Compare
Updated the gradient color logic to work for the range slider also. Now also upgraded the logic on the section label |
3309ca6
to
5d21163
Compare
Yes. That one is ok for me to skip with this PR. One final thing I noticed behavior-wise is that the active state for mark labels (when activeEqual is true) only works for the max value. That should probably test for all values. |
19e8a1d
to
b90ee5e
Compare
Updated the that the lower range value also is set as |
b90ee5e
to
97be535
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only 2 minor things left!
examples/src/stories/slider/examples/range-slider-with-section-example.tsx
Outdated
Show resolved
Hide resolved
97be535
to
04ac7ef
Compare
@axis-d0op The unresolved conversations blocks merging. How do I resolve them? |
@scharinger så, nu ska alla kommentarer vara resolved. du behöver synca in main och pusha, samt se till att alla kommits är signerade. (signed commits). |
e70e696
to
8092271
Compare
- make sliders take all width
- add sections defined a range with edges - add section labels - add section labels padding-bottom - add section track colors - make slider slider label be active - add option so mark is only active when equal to slider value
8092271
to
55ba78a
Compare
Rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM / samuel & jimmy
Describe your changes
We need a slider with sections that have labels and customable track colors.
Checklist before requesting a review