[#555] Add option to commit offsets #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
smcvb
requested review from
a team,
CodeDrivenMitch,
smcvb and
MateuszNaKodach
and removed request for
a team
smcvb
changed the title
smcvb
requested changes
Apr 18, 2025
There was a problem hiding this comment.
Conceptually I think there's nothing wrong with the changes. So, thanks for the effort there, @bradskuse! However, I do have some minor concerns we need to address. So, if you could take a look at those once you have found the time for that, that would be great.
...rc/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/OffsetCommitType.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/OffsetCommitType.java
Show resolved
Hide resolved
...rc/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/OffsetCommitType.java
Show resolved
Hide resolved
kafka/src/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/AsyncFetcher.java
Show resolved
Hide resolved
kafka/src/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/AsyncFetcher.java
Outdated
Show resolved
Hide resolved
kafka/src/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/AsyncFetcher.java
Show resolved
Hide resolved
...src/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/FetchEventsTask.java
Outdated
Show resolved
Hide resolved
...test/java/org/axonframework/extensions/kafka/eventhandling/consumer/FetchEventsTaskTest.java
Outdated
Show resolved
Hide resolved
|
Hey @smcvb Thank you for reviewing this PR. I have just pushed up all the changes requested 👍 |
smcvb
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #555
This adds an option so that offsets can be committed after processing of events, instead of using enable auto commit.
Edit: Added ability to use auto, async or sync