Fixed broken TODO lists' delete functionality

Author: Robbie-Microsoft

4-AccessControl/1-app-roles/App/controllers/todolistController.js

@@ -22,22 +22,23 @@ exports.getTodos = (req, res) => {
 }
 
 exports.postTodo = (req, res) => {
+    const owner = req.authContext.getAccount().idTokenClaims['oid'];
+    req.body._method === "DELETE" ? deleteTodo(req, owner) : addTodo(req, owner);
+    
+    res.redirect('/todolist');
+}
+
+const addTodo = (req, owner) => {
     const id = nanoid();
     const name = req.body.name;
-    const owner = req.authContext.getAccount().idTokenClaims['oid'];
 
     const newTodo = new Todo(id, name, owner)
 
     Todo.postTodo(newTodo);
-    
-    res.redirect('/todolist');
-}
+};
 
-exports.deleteTodo = (req, res) => {
+const deleteTodo = (req, owner) => {
     const id = req.body.id;
-    const owner = req.authContext.getAccount().idTokenClaims['oid'];
 
     Todo.deleteTodo(id, owner);
-
-    res.redirect('/todolist');
-}
+};

4-AccessControl/1-app-roles/App/routes/todolistRoutes.js

@@ -7,6 +7,5 @@ const router = express.Router();
 // user routes
 router.get('', todolistController.getTodos);
 router.post('/', todolistController.postTodo);
-router.delete('/', todolistController.deleteTodo);
 
 module.exports = router;

4-AccessControl/1-app-roles/App/views/todolist.ejs

@@ -30,7 +30,8 @@
                         <tr>
                             <td><%= todos[i]['name'] %></td>
                             <td>
-                                <form action='/todolist?_method=DELETE' method='POST'>
+                                <form action='/todolist' method='POST'>
+                                    <input type="hidden" name="_method" value="DELETE"/>
                                     <input type='hidden' name='id' value='<%= todos[i]["id"] %>'>
                                     <button class="btn btn-primary" type='submit'>Delete</button>
                                 </form>

4-AccessControl/2-security-groups/App/controllers/todolistController.js

@@ -22,22 +22,23 @@ exports.getTodos = (req, res) => {
 }
 
 exports.postTodo = (req, res) => {
+    const owner = req.authContext.getAccount().idTokenClaims['oid'];
+    req.body._method === "DELETE" ? deleteTodo(req, owner) : addTodo(req, owner);
+    
+    res.redirect('/todolist');
+}
+
+const addTodo = (req, owner) => {
     const id = nanoid();
     const name = req.body.name;
-    const owner = req.authContext.getAccount().idTokenClaims['oid'];
 
     const newTodo = new Todo(id, name, owner)
 
     Todo.postTodo(newTodo);
-    
-    res.redirect('/todolist');
-}
+};
 
-exports.deleteTodo = (req, res) => {
+const deleteTodo = (req, owner) => {
     const id = req.body.id;
-    const owner = req.authContext.getAccount().idTokenClaims['oid'];
 
     Todo.deleteTodo(id, owner);
-
-    res.redirect('/todolist');
-}
+};

4-AccessControl/2-security-groups/App/routes/todolistRoutes.js

@@ -5,8 +5,7 @@ const todolistController = require('../controllers/todolistController');
 const router = express.Router();
 
 // user routes
-router.get('/', todolistController.getTodos);
+router.get('', todolistController.getTodos);
 router.post('/', todolistController.postTodo);
-router.delete('/', todolistController.deleteTodo);
 
 module.exports = router;

4-AccessControl/2-security-groups/App/views/todolist.ejs

@@ -30,7 +30,8 @@
                         <tr>
                             <td><%= todos[i]['name'] %></td>
                             <td>
-                                <form action='/todolist?_method=DELETE' method='POST'>
+                                <form action='/todolist' method='POST'>
+                                    <input type="hidden" name="_method" value="DELETE"/>
                                     <input type='hidden' name='id' value='<%= todos[i]["id"] %>'>
                                     <button class="btn btn-primary" type='submit'>Delete</button>
                                 </form>