-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue of error when connecting to mssql with docker image or exe #2370
Conversation
npm install -g --loglevel verbose | ||
RUN npm pkg set scripts.prepare="echo no-prepare" | ||
|
||
RUN npm ci --unsafe-perm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to additionally add npm ci
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After Node16, the install -g
only copies content under local folder to global folder, it didn't install anything. npm ci
is to install dependencies into local folder first
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
- Would you please share the test result of the fix with docker/exe on SQL and loki?
- It's better to cover SQL server in test pipeline. (currently on my sql covered). If you don't want to add with this PR, you can open an issue to track it.
Thanks for contribution! Please go through following checklist before sending PR.
PR Branch Destination
main
branch.legacy-dev
branch.Always Add Test Cases
Make sure test cases are added to cover the code change.
Add Change Log
Add change log for the code change in
Upcoming Release
section inChangeLog.md
.Development Guideline
Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.