Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue of error when connecting to mssql with docker image or exe #2370

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

EmmaZhu
Copy link
Member

@EmmaZhu EmmaZhu commented Feb 29, 2024

Thanks for contribution! Please go through following checklist before sending PR.

PR Branch Destination

  • For Azurite V3, please send PR to main branch.
  • For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases

Make sure test cases are added to cover the code change.

Add Change Log

Add change log for the code change in Upcoming Release section in ChangeLog.md.

Development Guideline

Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

npm install -g --loglevel verbose
RUN npm pkg set scripts.prepare="echo no-prepare"

RUN npm ci --unsafe-perm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to additionally add npm ci?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After Node16, the install -g only copies content under local folder to global folder, it didn't install anything. npm ci is to install dependencies into local folder first

@EmmaZhu
Copy link
Member Author

EmmaZhu commented Mar 15, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@blueww blueww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

  1. Would you please share the test result of the fix with docker/exe on SQL and loki?
  2. It's better to cover SQL server in test pipeline. (currently on my sql covered). If you don't want to add with this PR, you can open an issue to track it.

@blueww
Copy link
Member

blueww commented Mar 25, 2024

@EmmaZhu

Would you please help to look at PR : #2380
It looks also try to upgrade node version in docker. However, the build script change in different way from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants