Skip to content

Commit 1874ac4

Browse files
aishwaryabhaishwaryabh
authored
Fixing Core tools tests (#4242)
1 parent dad128f commit 1874ac4

File tree

5 files changed

+21
-2
lines changed

5 files changed

+21
-2
lines changed

‎test/Azure.Functions.Cli.Tests/E2E/CreateFunctionTests.cs

+1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ await CliTester.Run(new RunConfiguration
4040
"new --template TimerTrigger --name testfunc --authlevel function"
4141
},
4242
HasStandardError = true,
43+
ExitInError = true,
4344
ErrorContains = new[]
4445
{
4546
Constants.AuthLevelErrorMessage

‎test/Azure.Functions.Cli.Tests/E2E/InitTests.cs

+5
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ public Task init_with_worker_runtime_and_unsupported_model(string workerRuntime,
171171
{
172172
Commands = new[] { $"init . --worker-runtime {workerRuntime} --model {programmingModel}" },
173173
HasStandardError = true,
174+
ExitInError = true,
174175
ErrorContains = new[]
175176
{
176177
$"programming model is not supported for worker runtime {workerRuntime}. Supported programming models for worker runtime {workerRuntime} are:"
@@ -278,6 +279,7 @@ public Task init_with_unknown_worker_runtime()
278279
{
279280
Commands = new[] { $"init . --worker-runtime {unknownWorkerRuntime}" },
280281
HasStandardError = true,
282+
ExitInError = true,
281283
ErrorContains = new[]
282284
{
283285
$"Worker runtime '{unknownWorkerRuntime}' is not a valid option."
@@ -293,6 +295,7 @@ public Task init_with_unsupported_target_framework_for_dotnet()
293295
{
294296
Commands = new[] { $"init . --worker-runtime dotnet --target-framework {unsupportedTargetFramework}" },
295297
HasStandardError = true,
298+
ExitInError = true,
296299
ErrorContains = new[]
297300
{
298301
$"Unable to parse target framework {unsupportedTargetFramework} for worker runtime dotnet. Valid options are net8.0, net6.0"
@@ -669,6 +672,7 @@ public Task init_docker_only_no_project()
669672
$"init . --docker-only"
670673
},
671674
HasStandardError = true,
675+
ExitInError = true,
672676
ErrorContains = new[]
673677
{
674678
$"Can't determine project language from files."
@@ -779,6 +783,7 @@ public Task init_managed_dependencies_is_only_supported_in_powershell()
779783
$"init . --worker-runtime python --managed-dependencies "
780784
},
781785
HasStandardError = true,
786+
ExitInError = true,
782787
ErrorContains = new[]
783788
{
784789
$"Managed dependencies is only supported for PowerShell"

‎test/Azure.Functions.Cli.Tests/E2E/StartTests.cs

+13-1
Original file line numberDiff line numberDiff line change
@@ -733,6 +733,7 @@ await CliTester.Run(new RunConfiguration[]
733733
$"start --port {_funcHostPort} --verbose --runtime inproc8"
734734
},
735735
ExpectExit = true,
736+
ExitInError = true,
736737
ErrorContains = ["Failed to locate the inproc8 model host"],
737738
Test = async (workingDir, p, _) =>
738739
{
@@ -766,6 +767,7 @@ await CliTester.Run(new RunConfiguration[]
766767
$"start --port {_funcHostPort} --verbose"
767768
},
768769
ExpectExit = true,
770+
ExitInError = true,
769771
ErrorContains = ["Failed to locate the inproc8 model host"],
770772
Test = async (workingDir, p, _) =>
771773
{
@@ -885,6 +887,7 @@ await CliTester.Run(new RunConfiguration[]
885887
$"start --port {_funcHostPort} --verbose"
886888
},
887889
ExpectExit = false,
890+
ExitInError = true,
888891
ErrorContains = ["Failed to locate the inproc6 model host at"],
889892
Test = async (workingDir, p, _) =>
890893
{
@@ -918,6 +921,7 @@ await CliTester.Run(new RunConfiguration[]
918921
$"start --port {_funcHostPort} --verbose --runtime inproc6"
919922
},
920923
ExpectExit = false,
924+
ExitInError = true,
921925
ErrorContains = ["Failed to locate the inproc6 model host at"],
922926
Test = async (workingDir, p, _) =>
923927
{
@@ -999,7 +1003,8 @@ await CliTester.Run(new RunConfiguration[]
9991003
{
10001004
$"start --port {_funcHostPort} --verbose --runtime inproc6"
10011005
},
1002-
ExpectExit = false,
1006+
ExpectExit = true,
1007+
ExitInError = true,
10031008
ErrorContains = ["The runtime argument value provided, 'inproc6', is invalid. The provided value is only valid for the worker runtime 'dotnet'."],
10041009
Test = async (workingDir, p, _) =>
10051010
{
@@ -1033,6 +1038,7 @@ await CliTester.Run(new RunConfiguration[]
10331038
$"start --port {_funcHostPort} --verbose --runtime inproc8"
10341039
},
10351040
ExpectExit = false,
1041+
ExitInError = true,
10361042
ErrorContains = ["The runtime argument value provided, 'inproc8', is invalid. The provided value is only valid for the worker runtime 'dotnet'."],
10371043
Test = async (workingDir, p, _) =>
10381044
{
@@ -1066,6 +1072,7 @@ await CliTester.Run(new RunConfiguration[]
10661072
$"start --port {_funcHostPort} --verbose --runtime inproc8"
10671073
},
10681074
ExpectExit = false,
1075+
ExitInError = true,
10691076
ErrorContains = ["The runtime argument value provided, 'inproc8', is invalid. For the 'inproc8' runtime, the 'FUNCTIONS_INPROC_NET8_ENABLED' environment variable must be set. See https://aka.ms/azure-functions/dotnet/net8-in-process."],
10701077
Test = async (workingDir, p, _) =>
10711078
{
@@ -1099,6 +1106,7 @@ await CliTester.Run(new RunConfiguration[]
10991106
$"start --port {_funcHostPort} --verbose --runtime default"
11001107
},
11011108
ExpectExit = false,
1109+
ExitInError = true,
11021110
ErrorContains = ["The runtime argument value provided, 'default', is invalid. The provided value is only valid for the worker runtime 'dotnetIsolated'."],
11031111
Test = async (workingDir, p, _) =>
11041112
{
@@ -1132,6 +1140,7 @@ await CliTester.Run(new RunConfiguration[]
11321140
$"start --port {_funcHostPort} --verbose --runtime default"
11331141
},
11341142
ExpectExit = false,
1143+
ExitInError = true,
11351144
ErrorContains = ["The runtime argument value provided, 'default', is invalid. The provided value is only valid for the worker runtime 'dotnetIsolated'."],
11361145
Test = async (workingDir, p, _) =>
11371146
{
@@ -1165,6 +1174,7 @@ await CliTester.Run(new RunConfiguration[]
11651174
$"start --port {_funcHostPort} --verbose --runtime inproc6"
11661175
},
11671176
ExpectExit = false,
1177+
ExitInError = true,
11681178
ErrorContains = ["The runtime argument value provided, 'inproc6', is invalid. For the 'inproc6' runtime, the 'FUNCTIONS_INPROC_NET8_ENABLED' environment variable cannot be be set. See https://aka.ms/azure-functions/dotnet/net8-in-process."],
11691179
Test = async (workingDir, p, _) =>
11701180
{
@@ -1199,6 +1209,7 @@ await CliTester.Run(new RunConfiguration[]
11991209
$"start --port {_funcHostPort} --verbose --runtime inproc6"
12001210
},
12011211
ExpectExit = false,
1212+
ExitInError = true,
12021213
ErrorContains = ["The runtime argument value provided, 'inproc6', is invalid. The provided value is only valid for the worker runtime 'dotnet'."],
12031214
Test = async (workingDir, p, _) =>
12041215
{
@@ -1233,6 +1244,7 @@ await CliTester.Run(new RunConfiguration[]
12331244
$"start --port {_funcHostPort} --verbose --runtime inproc8"
12341245
},
12351246
ExpectExit = false,
1247+
ExitInError = true,
12361248
ErrorContains = ["The runtime argument value provided, 'inproc8', is invalid. The provided value is only valid for the worker runtime 'dotnet'."],
12371249
Test = async (workingDir, p, _) =>
12381250
{

‎test/Azure.Functions.Cli.Tests/E2E/StartTests_default.runsettings

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<RunSettings>
33
<RunConfiguration>
4-
<TestCaseFilter>(Group != RequiresNestedInProcArtifacts AND Group != UseInVisualStudioConsolidatedArtifactGeneration)</TestCaseFilter>
4+
<TestCaseFilter>(Group != RequiresNestedInProcArtifacts) &amp; (Group != UseInVisualStudioConsolidatedArtifactGeneration) &amp; (Group != UseInConsolidatedArtifactGeneration)</TestCaseFilter>
55
</RunConfiguration>
66
</RunSettings>

‎test/Azure.Functions.Cli.Tests/ExtensionsTests/ExtensionBundleTests.cs

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ public Task BundleConfiguredByDefault_no_action()
2828
{
2929
"No action performed"
3030
},
31+
ExitInError = true,
3132
CommandTimeout = TimeSpan.FromMinutes(300)
3233
}, _output);
3334
}

0 commit comments

Comments
 (0)