Move invocation logging into a thread pool executor #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the logging call inside the function invocation callback into a thread pool executor (With a max size of 1).
Effectively allows the logging call to happen concurrently with the function invocation.
In real-terms, with a patched function host, the response times were:
At the 95th percentile an improvement of 7ms per request (18%).
IF the customer is using logging inside their function, we should consider making the thread pool executor available/patched on the logger instance.