feat: support for async sdk types #1495
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to support aio blob client types, the
decode()
method needs to be async. This is currently not supported, because thefrom_incoming_proto()
method in the worker, wheredecode()
is called, is a sync call.This changes
from_incoming_proto()
to be an async method instead.Tests are added for the new async blob client types to test this change. These new tests will fail until a new blob extension version with the aio types is released.
Fixes #
PR information
Quality of Code and Contribution Guidelines