Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for async sdk types #1495

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

Conversation

hallvictoria
Copy link
Contributor

@hallvictoria hallvictoria commented May 13, 2024

Description

In order to support aio blob client types, the decode() method needs to be async. This is currently not supported, because the from_incoming_proto() method in the worker, where decode() is called, is a sync call.

This changes from_incoming_proto() to be an async method instead.

Tests are added for the new async blob client types to test this change. These new tests will fail until a new blob extension version with the aio types is released.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant