Sync eng/common directory with azure-sdk-tools for PR 10432 (#40691)

* Update workflow sync pipeline

* Remove exit code check as the list of files should be good enough

---------

Co-authored-by: Wes Haggard <[email protected]>

Author: azure-sdk

eng/common/pipelines/templates/steps/eng-common-workflow-enforcer.yml

@@ -11,8 +11,8 @@ steps:
 
         if ((!"$(System.PullRequest.SourceBranch)".StartsWith("sync-eng/common")) -and "$(System.PullRequest.TargetBranch)" -match "^(refs/heads/)?$(DefaultBranch)$")
         {
-          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath 'eng/common/*' -DiffFilterType ""
-          if (($LASTEXITCODE -eq 0) -and ($filesInCommonDir.Count -gt 0))
+          $filesInCommonDir = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath 'eng/common/*' -DiffFilterType ""
+          if ($filesInCommonDir.Count -gt 0)
           {
             Write-Host "##vso[task.LogIssue type=error;]Changes to files under 'eng/common' directory should not be made in this Repo`n${filesInCommonDir}"
             Write-Host "##vso[task.LogIssue type=error;]Please follow workflow at https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/common_engsys.md"
@@ -21,8 +21,13 @@ steps:
         }
         if ((!"$(System.PullRequest.SourceBranch)".StartsWith("sync-.github/workflows")) -and "$(System.PullRequest.TargetBranch)" -match "^(refs/heads/)?$(DefaultBranch)$")
         {
-          $filesInCommonDir  = & "eng/common/scripts/get-changedfiles.ps1" -DiffPath '.github/workflows/*event*' -DiffFilterType ""
-          if (($LASTEXITCODE -eq 0) -and ($filesInCommonDir.Count -gt 0))
+          # This list needs to be kept in sync with the FilePatterns listed in eng/pipelines/eng-workflows-sync.yml
+          $filePatterns = @(".github/workflows/*event*", ".github/workflows/post-apiview.yml")
+          $filesInCommonDir = @()
+          foreach ($filePattern in $filePatterns) {
+            $filesInCommonDir += & "eng/common/scripts/get-changedfiles.ps1" -DiffPath $filePattern -DiffFilterType ""
+          }
+          if ($filesInCommonDir.Count -gt 0)
           {
             Write-Host "##vso[task.LogIssue type=error;]Changes to files under '.github/workflows' directory should not be made in this Repo`n${filesInCommonDir}"
             Write-Host "##vso[task.LogIssue type=error;]Please follow workflow at https://github.com/Azure/azure-sdk-tools/blob/main/doc/workflows/engsys_workflows.md"