Skip to content

Commit 7e6ad3d

Browse files
authored
[SchemaRegistry] pylint (#40709)
* lint * [SchemaRegistry] lint * add _utils * fix verifytypes
1 parent 32f976b commit 7e6ad3d

File tree

25 files changed

+3340
-40
lines changed

25 files changed

+3340
-40
lines changed

sdk/schemaregistry/azure-schemaregistry-avroencoder/azure/schemaregistry/encoder/avroencoder/aio/_async_lru.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
# 2. The last update to the library was a year ago, so it seems the library is
3030
# not being actively maintained.
3131

32-
import asyncio
32+
import asyncio # pylint:disable=do-not-import-asyncio
3333
from collections import OrderedDict
3434
from functools import _CacheInfo, _make_key, partial, wraps
3535

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"CrossLanguagePackageId": "SchemaRegistry",
3+
"CrossLanguageDefinitionId": {
4+
"azure.schemaregistry.models.SchemaContentTypeValues": "SchemaRegistry.SchemaContentTypeValues"
5+
}
6+
}

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/__init__.py

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
if TYPE_CHECKING:
1313
from ._patch import * # pylint: disable=unused-wildcard-import
1414

15-
from ._client import SchemaRegistryClient # type: ignore
1615
from ._version import VERSION
1716

1817
__version__ = VERSION

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_client.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from ._configuration import SchemaRegistryClientConfiguration
1818
from ._operations import SchemaRegistryClientOperationsMixin
19-
from ._serialization import Deserializer, Serializer
19+
from ._utils.serialization import Deserializer, Serializer
2020

2121
if TYPE_CHECKING:
2222
from azure.core.credentials import TokenCredential
@@ -41,6 +41,7 @@ def __init__(self, fully_qualified_namespace: str, credential: "TokenCredential"
4141
self._config = SchemaRegistryClientConfiguration(
4242
fully_qualified_namespace=fully_qualified_namespace, credential=credential, **kwargs
4343
)
44+
4445
_policies = kwargs.pop("policies", None)
4546
if _policies is None:
4647
_policies = [

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_model_base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -633,7 +633,7 @@ def _deserialize(cls, data, exist_discriminators):
633633
discriminator_value = data.find(xml_name).text # pyright: ignore
634634
else:
635635
discriminator_value = data.get(discriminator._rest_name)
636-
mapped_cls = cls.__mapping__.get(discriminator_value, cls) # pyright: ignore
636+
mapped_cls = cls.__mapping__.get(discriminator_value, cls) # pyright: ignore # pylint: disable=no-member
637637
return mapped_cls._deserialize(data, exist_discriminators)
638638

639639
def as_dict(self, *, exclude_readonly: bool = False) -> typing.Dict[str, typing.Any]:

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_operations/_operations.py

+9-12
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
# Code generated by Microsoft (R) Python Code Generator.
66
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
77
# --------------------------------------------------------------------------
8-
import json # pylint: disable=unused-import
9-
import sys
8+
from collections.abc import MutableMapping
109
from typing import Any, Callable, Dict, Iterable, Iterator, List, Optional, TypeVar
1110
import urllib.parse
1211

12+
from azure.core import PipelineClient
1313
from azure.core.exceptions import (
1414
ClientAuthenticationError,
1515
HttpResponseError,
@@ -26,14 +26,11 @@
2626
from azure.core.tracing.decorator import distributed_trace
2727
from azure.core.utils import case_insensitive_dict
2828

29-
from .._model_base import SdkJSONEncoder, _deserialize # pylint: disable=unused-import
30-
from .._serialization import Serializer
31-
from .._vendor import SchemaRegistryClientMixinABC
29+
from .._configuration import SchemaRegistryClientConfiguration
30+
from .._utils.model_base import _deserialize
31+
from .._utils.serialization import Serializer
32+
from .._utils.utils import ClientMixinABC
3233

33-
if sys.version_info >= (3, 9):
34-
from collections.abc import MutableMapping
35-
else:
36-
from typing import MutableMapping # type: ignore
3734
T = TypeVar("T")
3835
ClsType = Optional[Callable[[PipelineResponse[HttpRequest, HttpResponse], T, Dict[str, Any]], Any]]
3936

@@ -201,7 +198,7 @@ def build_schema_registry_register_schema_request( # pylint: disable=name-too-l
201198
return HttpRequest(method="PUT", url=_url, params=_params, headers=_headers, **kwargs)
202199

203200

204-
class SchemaRegistryClientOperationsMixin(SchemaRegistryClientMixinABC):
201+
class SchemaRegistryClientOperationsMixin(ClientMixinABC[PipelineClient, SchemaRegistryClientConfiguration]):
205202

206203
@distributed_trace
207204
def _list_schema_groups(self, **kwargs: Any) -> Iterable[str]:
@@ -271,7 +268,7 @@ def prepare_request(next_link=None):
271268

272269
def extract_data(pipeline_response):
273270
deserialized = pipeline_response.http_response.json()
274-
list_of_elem = _deserialize(List[str], deserialized["Value"])
271+
list_of_elem = _deserialize(List[str], deserialized.get("Value", []))
275272
if cls:
276273
list_of_elem = cls(list_of_elem) # type: ignore
277274
return deserialized.get("NextLink") or None, iter(list_of_elem)
@@ -367,7 +364,7 @@ def prepare_request(next_link=None):
367364

368365
def extract_data(pipeline_response):
369366
deserialized = pipeline_response.http_response.json()
370-
list_of_elem = _deserialize(List[int], deserialized["Value"])
367+
list_of_elem = _deserialize(List[int], deserialized.get("Value", []))
371368
if cls:
372369
list_of_elem = cls(list_of_elem) # type: ignore
373370
return deserialized.get("NextLink") or None, iter(list_of_elem)

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_operations/_patch.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class SchemaRegistryClientOperationsMixin(GeneratedClientOperationsMixin):
9696
"""
9797

9898
@distributed_trace
99-
def _get_schema_properties_by_content( # type: ignore[override] # pylint: disable=inconsistent-return-statements
99+
def _get_schema_properties_by_content( # type: ignore[override] # pylint: disable=inconsistent-return-statements
100100
self,
101101
group_name: str,
102102
schema_name: str,
@@ -186,7 +186,7 @@ def _get_schema_properties_by_content( # type: ignore[override] # pylint: disabl
186186
return cls(pipeline_response, None, response_headers)
187187

188188
@distributed_trace
189-
def _register_schema( # type: ignore[override] # pylint: disable=inconsistent-return-statements
189+
def _register_schema( # type: ignore[override] # pylint: disable=inconsistent-return-statements
190190
self,
191191
group_name: str,
192192
schema_name: str,

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_patch.py

+1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# pylint: disable=line-too-long,useless-suppression
12
# ------------------------------------
23
# Copyright (c) Microsoft Corporation.
34
# Licensed under the MIT License.

sdk/schemaregistry/azure-schemaregistry/azure/schemaregistry/_serialization.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# pylint: disable=too-many-lines
1+
# pylint: disable=too-many-lines,line-too-long,useless-suppression
22
# --------------------------------------------------------------------------
33
#
44
# Copyright (c) Microsoft Corporation. All rights reserved.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# --------------------------------------------------------------------------
2+
# Copyright (c) Microsoft Corporation. All rights reserved.
3+
# Licensed under the MIT License. See License.txt in the project root for license information.
4+
# Code generated by Microsoft (R) Python Code Generator.
5+
# Changes may cause incorrect behavior and will be lost if the code is regenerated.
6+
# --------------------------------------------------------------------------

0 commit comments

Comments
 (0)