use CommunicationError instead of AvailablePhoneNumberError

Author: danielortega-msft

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/__init__.py

@@ -25,8 +25,7 @@
     OperatorInformationResult,
     PhoneNumbersBrowseResult,
     AvailablePhoneNumber,
-    PhoneNumbersReservation,
-    ErrorDetail
+    PhoneNumbersReservation
 )
 
 from ._generated.models._enums import (
@@ -56,6 +55,5 @@
     'PhoneNumbersBrowseResult',
     'AvailablePhoneNumber',
     'ReservationStatus',
-    'PhoneNumberAvailabilityStatus',
-    'ErrorDetail'
+    'PhoneNumberAvailabilityStatus'
 ]

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/_generated/models/__init__.py

@@ -18,9 +18,6 @@
     AvailablePhoneNumberError,
     CommunicationError,
     CommunicationErrorResponse,
-    ErrorAdditionalInfo,
-    ErrorDetail,
-    ErrorResponse,
     OperatorDetails,
     OperatorInformation,
     OperatorInformationOptions,
@@ -67,9 +64,6 @@
     "AvailablePhoneNumberError",
     "CommunicationError",
     "CommunicationErrorResponse",
-    "ErrorAdditionalInfo",
-    "ErrorDetail",
-    "ErrorResponse",
     "OperatorDetails",
     "OperatorInformation",
     "OperatorInformationOptions",

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/_generated/models/_models.py

@@ -48,8 +48,8 @@ class AvailablePhoneNumber(_serialization.Model):
      true, the phone number cannot be acquired unless the customer provides explicit agreement to
      not resell it.
     :vartype is_agreement_to_not_resell_required: bool
-    :ivar error: The error detail.
-    :vartype error: ~azure.communication.phonenumbers.models.ErrorDetail
+    :ivar error: The Communication Services error.
+    :vartype error: ~azure.communication.phonenumbers.models.CommunicationError
     """
 
     _validation = {
@@ -74,7 +74,7 @@ class AvailablePhoneNumber(_serialization.Model):
         "cost": {"key": "cost", "type": "PhoneNumberCost"},
         "status": {"key": "status", "type": "str"},
         "is_agreement_to_not_resell_required": {"key": "isAgreementToNotResellRequired", "type": "bool"},
-        "error": {"key": "error", "type": "ErrorDetail"},
+        "error": {"key": "error", "type": "CommunicationError"},
     }
 
     def __init__(
@@ -84,7 +84,7 @@ def __init__(
         capabilities: "_models.PhoneNumberCapabilities",
         phone_number_type: Union[str, "_models.PhoneNumberType"],
         assignment_type: Union[str, "_models.PhoneNumberAssignmentType"],
-        error: Optional["_models.ErrorDetail"] = None,
+        error: Optional["_models.CommunicationError"] = None,
         **kwargs: Any
     ) -> None:
         """
@@ -99,8 +99,8 @@ def __init__(
          case. Required. Known values are: "person" and "application".
         :paramtype assignment_type: str or
          ~azure.communication.phonenumbers.models.PhoneNumberAssignmentType
-        :keyword error: The error detail.
-        :paramtype error: ~azure.communication.phonenumbers.models.ErrorDetail
+        :keyword error: The Communication Services error.
+        :paramtype error: ~azure.communication.phonenumbers.models.CommunicationError
         """
         super().__init__(**kwargs)
         self.id: Optional[str] = None
@@ -221,98 +221,6 @@ def __init__(self, *, error: "_models.CommunicationError", **kwargs: Any) -> Non
         self.error = error
 
 
-class ErrorAdditionalInfo(_serialization.Model):
-    """The resource management error additional info.
-
-    Variables are only populated by the server, and will be ignored when sending a request.
-
-    :ivar type: The additional info type.
-    :vartype type: str
-    :ivar info: The additional info.
-    :vartype info: JSON
-    """
-
-    _validation = {
-        "type": {"readonly": True},
-        "info": {"readonly": True},
-    }
-
-    _attribute_map = {
-        "type": {"key": "type", "type": "str"},
-        "info": {"key": "info", "type": "object"},
-    }
-
-    def __init__(self, **kwargs: Any) -> None:
-        """ """
-        super().__init__(**kwargs)
-        self.type: Optional[str] = None
-        self.info: Optional[JSON] = None
-
-
-class ErrorDetail(_serialization.Model):
-    """The error detail.
-
-    Variables are only populated by the server, and will be ignored when sending a request.
-
-    :ivar code: The error code.
-    :vartype code: str
-    :ivar message: The error message.
-    :vartype message: str
-    :ivar target: The error target.
-    :vartype target: str
-    :ivar details: The error details.
-    :vartype details: list[~azure.communication.phonenumbers.models.ErrorDetail]
-    :ivar additional_info: The error additional info.
-    :vartype additional_info: list[~azure.communication.phonenumbers.models.ErrorAdditionalInfo]
-    """
-
-    _validation = {
-        "code": {"readonly": True},
-        "message": {"readonly": True},
-        "target": {"readonly": True},
-        "details": {"readonly": True},
-        "additional_info": {"readonly": True},
-    }
-
-    _attribute_map = {
-        "code": {"key": "code", "type": "str"},
-        "message": {"key": "message", "type": "str"},
-        "target": {"key": "target", "type": "str"},
-        "details": {"key": "details", "type": "[ErrorDetail]"},
-        "additional_info": {"key": "additionalInfo", "type": "[ErrorAdditionalInfo]"},
-    }
-
-    def __init__(self, **kwargs: Any) -> None:
-        """ """
-        super().__init__(**kwargs)
-        self.code: Optional[str] = None
-        self.message: Optional[str] = None
-        self.target: Optional[str] = None
-        self.details: Optional[List["_models.ErrorDetail"]] = None
-        self.additional_info: Optional[List["_models.ErrorAdditionalInfo"]] = None
-
-
-class ErrorResponse(_serialization.Model):
-    """Common error response for all Azure Resource Manager APIs to return error details for failed
-    operations. (This also follows the OData error response format.).
-
-    :ivar error: The error object.
-    :vartype error: ~azure.communication.phonenumbers.models.ErrorDetail
-    """
-
-    _attribute_map = {
-        "error": {"key": "error", "type": "ErrorDetail"},
-    }
-
-    def __init__(self, *, error: Optional["_models.ErrorDetail"] = None, **kwargs: Any) -> None:
-        """
-        :keyword error: The error object.
-        :paramtype error: ~azure.communication.phonenumbers.models.ErrorDetail
-        """
-        super().__init__(**kwargs)
-        self.error = error
-
-
 class OfferingsResponse(_serialization.Model):
     """Represents a wrapper around a list of offerings.
 

sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/_generated/operations/_operations.py

@@ -632,7 +632,7 @@ class PhoneNumbersOperations:  # pylint: disable=too-many-public-methods
 
     models = _models
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, *args, **kwargs) -> None:
         input_args = list(args)
         self._client: PipelineClient = input_args.pop(0) if input_args else kwargs.pop("client")
         self._config: PhoneNumbersClientConfiguration = input_args.pop(0) if input_args else kwargs.pop("config")

sdk/communication/azure-communication-phonenumbers/swagger/PHONE_NUMBER_SWAGGER.md

@@ -12,8 +12,6 @@ autorest ./PHONE_NUMBER_SWAGGER.md
 ``` yaml
 tag: package-phonenumber-2025-04-01
 require: https://raw.githubusercontent.com/Azure/azure-rest-api-specs/de9cb12d2840ca0915849ce6a3bf8c956a32c022/specification/communication/data-plane/PhoneNumbers/readme.md
-input-file: 
-  - https://raw.githubusercontent.com/Azure/azure-rest-api-specs/refs/heads/main/specification/common-types/data-plane/v1/types.json
 output-folder: ../azure/communication/phonenumbers/_generated
 namespace: azure.communication.phonenumbers
 license-header: MICROSOFT_MIT_NO_VERSION
@@ -57,12 +55,12 @@ directive:
     $["name"] = "PhoneNumberAvailabilityStatus";
 ```
 
-### Replace type from AvailablePhoneNumberError to ResponseError
+### Replace type from AvailablePhoneNumberError to CommunicationError
 ```yaml
 directive:
   - from: swagger-document
     where: $.definitions.AvailablePhoneNumber.properties.error
     transform: >
       $.type = "object";
-      $.$ref = "https://raw.githubusercontent.com/Azure/azure-rest-api-specs/refs/heads/main/specification/common-types/data-plane/v1/types.json#/definitions/ErrorDetail";
+      $.$ref = "../../../Common/stable/2021-03-07/common.json#/definitions/CommunicationError";
 ```