Skip to content

Address 1ES release warning #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
scbedd opened this issue Feb 13, 2025 · 1 comment · Fixed by #2140 · May be fixed by #2349
Open
1 of 3 tasks

Address 1ES release warning #2149

scbedd opened this issue Feb 13, 2025 · 1 comment · Fixed by #2140 · May be fixed by #2349
Assignees
@hallipr
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@scbedd
Copy link
Member

scbedd commented Feb 13, 2025 •
edited by hallipr
Loading

We want to eliminate this warning that is appearing on ALL js release pipelines.

Reference this PR for a summary of the necessary changes.

1ES reference

Need to:

  • Eliminate any download or checkout usage in the deployment job
  • Ensure that only the release job in the stage is actually a deployment with templateContext setting it to a release job. The rest should be moved to regular job instead of deployments
    • Functionally this looks like adding a templateContext identifying input artifacts

We need to update

  • archtype-rust-release
@github-project-automation github-project-automation bot moved this to Untriaged in Azure SDK Rust Feb 13, 2025
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 13, 2025
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Feb 13, 2025
@kurtzeborn kurtzeborn moved this from 🤔 Triage to 📋 Backlog in Azure SDK EngSys 🥧📅 Feb 13, 2025
@kurtzeborn kurtzeborn moved this from 📋 Backlog to 🐝 Dev in Azure SDK EngSys 🥧📅 Mar 6, 2025
@hallipr hallipr linked a pull request Mar 21, 2025 that will close this issue
Use native cargo commands for crates.io work #2140
Merged
@hallipr
Copy link
Member

hallipr commented Mar 21, 2025 •
edited
Loading

partially fixed in #2140
should be completed in #2349

@hallipr hallipr moved this from 🐝 Dev to 🔬 Dev in PR in Azure SDK EngSys 🥧📅 Mar 24, 2025
@hallipr hallipr linked a pull request Mar 24, 2025 that will close this issue
Use -Zpackage-workspace for packing #2349
Open
@RickWinter RickWinter moved this from Untriaged to In Progress in Azure SDK Rust Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallipr hallipr

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Azure SDK EngSys 🥧📅
Status: 🔬 Dev in PR
Azure SDK Rust
Status: In Progress
Milestone
No milestone
3 participants
@hallipr @kurtzeborn @scbedd