Update string translation actions, remove PAT token usage (#5314)

Author: JamesBurnside

.github/workflows/run-td-build.yml

@@ -1,6 +1,9 @@
 # Touchdown build pipeline
 
-trigger: none
+trigger:
+  branches:
+    include:
+      - main
 pr: none
 
 resources:
@@ -9,6 +12,14 @@ resources:
       type: git
       name: 1ESPipelineTemplates/M365GPT
       ref: refs/tags/release
+
+parameters:
+  # Parameter to control whether to only pass strings to touchdown (false) or to also create a PR with changes (true)
+  - name: commit_new_strings
+    displayName: 'Commit strings to GitHub'
+    type: boolean
+    default: false
+
 extends:
   template: v1/M365.Unofficial.PipelineTemplate.yml@m365Pipelines
   parameters:
@@ -51,24 +62,15 @@ extends:
                 displayName: 'Call Touchdown build task for composites and commit changes'
 
               - task: PowerShell@2
-                displayName: Push changes to repo
+                displayName: Commit changes to a new branch
+                condition: eq('${{ parameters.commit_new_strings }}', true) # Only create a PR if the parameter is set to true
                 inputs:
                   targetType: 'inline'
                   script: |
                     # ------------------------------------------------------------------------------------------------
-                    # - Script to push changes
+                    # - Script to create a new branch in the GitHub repo with string changes
                     # ------------------------------------------------------------------------------------------------
 
-                    $teamProject = $env:SYSTEM_TEAMPROJECT
-                    $repoName= $env:Build_Repository_Name
-                    $pipelineName = $env:Build_DefinitionName
-
-                    Write-host "Azure DevOps organization: $env:System_TeamFoundationCollectionUri"
-                    Write-host "Team Project: $teamProject"
-                    Write-host "Repo Name: $repoName"
-                    Write-host "Source Branch: $(Build.SourceBranch)"
-
-
                     if ("$(git status)".Contains("nothing to commit")) {
                         Write-Host "Nothing to commit, exiting immediately"
                         Exit
@@ -79,33 +81,25 @@ extends:
                     #****************************************
                     Write-Host "##[group] Configure GIT"
 
-                    #Setting Global Git Username and Email. NOTE: Branch will be created as this user
+                    # Setting Global Git Username and Email. NOTE: Branch will be created as this user
                     git config user.email "41898282+github-actions[bot]@users.noreply.github.com"
                     git config user.name "github-actions[bot]"
 
-                    #**********************************************
-                    #***Checkout current branch and push changes***
-                    #**********************************************
-
-                    Write-Host "##[group] Checkout current branch and push changes"
-                    #Create Branch and add changes
+                    #**************************************************
+                    #*** Create a new branch and push changes to it ***
+                    #**************************************************
 
-                    Write-Host "Checkout current branch"
+                    # Get the current date and time in the format yyyyMMdd-HHmmss
+                    $dateTime = Get-Date -Format "yyyyMMdd-HHmmss"
+                    $newBranchName = "td/update-strings-$dateTime"
 
-                    $branchName = "$(Build.SourceBranch)"
-                    $branchName = $branchName -replace "refs/heads/", ""
-
-                    git checkout $branchName
+                    Write-Host "Creating new branch $newBranchName"
+                    git checkout -b $newBranchName
                     git add -A
-                    git commit -m "TDBuild latest localization" -a
-                    git push origin $branchName
+                    git commit -m "TDBuild latest localization"
+                    git push origin $newBranchName
 
-                    if (!$?) {
-                      # We ignore stderr (in task definition) due to git loving to write there even when things are fine.
-                      Write-Host "The git push command failed. Exiting."
-                      Exit 1
-                    }
-                condition: eq(variables['commit'], 'true')
+                    Write-Host "PR created successfully: $($response.url)"
     sdl:
       arrow:
         serviceConnection: Arrow_skype_PROD

.github/workflows/touchdown-pipeline/touchdown-build.yml

@@ -2,18 +2,19 @@
 
 [@azure/communication-react](https://www.npmjs.com/package/@azure/communication-react) includes translations of all strings used internally to a set of supported languages.
 
-We use a Microsoft internal translation service for string translations. Strings are automatically sent for translation via a [GitHub action](https://github.com/Azure/communication-ui-library/actions/workflows/run-td-build.yml) on pushes to the `main`.
+We use a Microsoft internal translation service for string translations. Strings are automatically sent for translation when pushed to main. This is done via an internal Azure Pipeline.
 
 **Strings are not committed back into the repository automatically**. This is to avoid surprises due to mis-translated strings and so that test snapshots can be updated to reflect the new strings.
 
-To fetch back strings:
+## Pulling strings back to the repo
 
-* Create a new branch off of `main` and trigger the same [GitHub action](https://github.com/Azure/communication-ui-library/actions/workflows/run-td-build.yml).
-* Pick your new branch to run the workflow and check the option to commit updated strings.
-  ![Trigger strings translation action](../images/trigger-strings-translation-and-fetch.png)
-* Follow the [usual process](../contributing-guide/6.%20submitting-a-pr.md) for merging the PR into `main`.
-* You _may_ need to add the `update_snapshots` label to the PR to update [e2e test snapshots](../references/ui-tests.md) if the e2e tests fail.
+To pull strings back to the repo:
 
-**Note**: String translation can take up to 5 working days to complete. Be careful when making (i.e., cherry-picking into a release branch) string changes close to a release.
+- Run the internal Azure pipeline manually and select `Commit strings to GitHub`.
+  - This will create a branch called `td/new-strings-<datetime>` with the new strings.
+  - This pipeline can br run off any branch and the strings will be translated from that branch. We typically run it off `main` or a `release` branch.
+- Then create a PR to merge this branch into your desired branch.
+
+## References
 
 Further reading: [Internal documentation](https://skype.visualstudio.com/SPOOL/_wiki/wikis/SPOOL.wiki/25949/Localization) for details on how string translation service is setup.