[Bugfix] Remove unreachable code (#5520)

Author: jimchou-dev

change-beta/@azure-communication-react-84f1f7b4-4854-4450-9214-b4b3ec9c47d5.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "",
+  "comment": "Remove unreachable code",
+  "packageName": "@azure/communication-react",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

change/@azure-communication-react-84f1f7b4-4854-4450-9214-b4b3ec9c47d5.json

@@ -0,0 +1,9 @@
+{
+  "type": "patch",
+  "area": "fix",
+  "workstream": "",
+  "comment": "Remove unreachable code",
+  "packageName": "@azure/communication-react",
+  "email": "[email protected]",
+  "dependentChangeType": "patch"
+}

packages/calling-component-bindings/src/handlers/createHandlers.ts

@@ -15,7 +15,6 @@ import { _toCommunicationIdentifier } from '@internal/acs-ui-common';
 import { DeclarativeCallAgent } from '@internal/calling-stateful-client';
 import { StatefulCallClient, StatefulDeviceManager } from '@internal/calling-stateful-client';
 import memoizeOne from 'memoize-one';
-import { isACSCallParticipants } from '../utils/callUtils';
 import { createLocalVideoStream } from '../utils/callUtils';
 import { createDefaultCommonCallingHandlers, CommonCallingHandlers } from './createCommonHandlers';
 
@@ -83,10 +82,6 @@ export const createDefaultCallingHandlers: CreateDefaultCallingHandlers = memoiz
     // FIXME: onStartCall API should use string, not the underlying SDK types.
     onStartCall: (participants: CommunicationIdentifier[], options?: StartCallOptions): Call | undefined => {
       return callAgent?.startCall(participants, options);
-      if (!isACSCallParticipants(participants)) {
-        throw new Error('TeamsUserIdentifier in Teams call is not supported!');
-      }
-      return callAgent?.startCall(participants, options);
     },
     onAddParticipant: async (
       userId: string | CommunicationIdentifier,

packages/calling-component-bindings/src/participantListSelector.ts

@@ -43,7 +43,6 @@ const convertRemoteParticipantsToParticipantListParticipants = (
         // Filter out MicrosoftBot participants
         .filter((participant: RemoteParticipantState) => {
           return !isMicrosoftTeamsAppIdentifier(participant.identifier);
-          return true;
         })
         /**
          * hiding participants who are inLobby, idle, or connecting in ACS clients till we can admit users through ACS clients.

packages/react-components/src/components/ChatMessage/ChatMessageContent.tsx

@@ -244,7 +244,6 @@ export const getAttachmentCountLiveMessage = (
   return _formatString(attachmentCardGroupMessage, {
     attachmentCount: `${attachments.length}`
   });
-  return '';
 };
 
 const defaultOnRenderInlineImage = (inlineImage: InlineImage): JSX.Element => {

packages/react-components/src/components/LocalVideoTile.tsx

@@ -154,7 +154,6 @@ export const _LocalVideoTile = React.memo(
       return {
         contextualMenu: contextualMenuProps
       };
-      return {};
     }, [contextualMenuProps, menuKind]);
 
     const videoTileStyles = useMemo(() => {

packages/react-components/src/components/VideoGallery.tsx

@@ -508,7 +508,6 @@ export const VideoGallery = (props: VideoGalleryProps): JSX.Element => {
 
     const showDisplayNameTrampoline = (): string => {
       return layout === 'default' ? strings.localVideoLabel : isNarrow ? '' : strings.localVideoLabel;
-      return isNarrow ? '' : strings.localVideoLabel;
     };
 
     return (

packages/react-components/src/components/VideoGallery/DefaultLayout.tsx

@@ -150,5 +150,4 @@ const overflowGalleryTrampoline = (
   galleryPosition?: 'horizontalBottom' | 'verticalRight' | 'horizontalTop'
 ): JSX.Element | null => {
   return galleryPosition !== 'horizontalTop' ? gallery : <></>;
-  return gallery;
 };

packages/react-components/src/components/VideoGallery/FloatingLocalVideoLayout.tsx

@@ -240,5 +240,4 @@ const overflowGalleryTrampoline = (
   galleryPosition?: 'horizontalBottom' | 'verticalRight' | 'horizontalTop'
 ): JSX.Element | null => {
   return galleryPosition !== 'horizontalTop' ? gallery : <></>;
-  return gallery;
 };

packages/react-components/src/components/VideoGallery/SpeakerVideoLayout.tsx

@@ -208,5 +208,4 @@ const overflowGalleryTrampoline = (
   galleryPosition?: 'horizontalBottom' | 'verticalRight' | 'horizontalTop'
 ): JSX.Element | null => {
   return galleryPosition !== 'horizontalTop' ? gallery : <></>;
-  return gallery;
 };

packages/react-components/src/components/utils/ChatMessageComponentUtils.tsx

@@ -103,7 +103,6 @@ const defaultOnRenderAttachmentDownloads = (
   ) : (
     <></>
   );
-  return undefined;
 };
 
 /** @private */

packages/react-composites/src/composites/CallComposite/components/CallArrangement.tsx

@@ -345,7 +345,6 @@ export const CallArrangement = (props: CallArrangementProps): JSX.Element => {
       onStopAllSpotlight: hideSpotlightButtons ? undefined : stopAllSpotlightWithPrompt,
       maxParticipantsToSpotlight
     };
-    return {};
   }, [
     hideSpotlightButtons,
     maxParticipantsToSpotlight,

packages/react-composites/src/composites/CallComposite/components/MediaGallery.tsx

@@ -189,7 +189,6 @@ export const MediaGallery = (props: MediaGalleryProps): JSX.Element => {
   const VideoGalleryMemoized = useMemo(() => {
     const layoutBasedOnUserSelection = (): VideoGalleryLayout => {
       return props.localVideoTileOptions ? layoutBasedOnTilePosition : props.userSetGalleryLayout;
-      return layoutBasedOnTilePosition;
     };
 
     return (

packages/react-composites/src/composites/CallComposite/components/buttons/ScreenShare.tsx

@@ -24,7 +24,6 @@ export const ScreenShare = (props: {
 
   const screenShareButtonDisabled = (): boolean => {
     return screenShareButtonProps?.disabled ?? isDisabled(props.option);
-    return isDisabled(props.option);
   };
 
   return (

packages/react-composites/src/composites/common/CallingDialpad.tsx

@@ -84,8 +84,6 @@ export const CallingDialpad = (props: CallingDialpadProps): JSX.Element => {
         />
       </>
     );
-
-    return <></>;
   };
 
   if (isMobile) {

packages/react-composites/src/composites/common/PeoplePaneContent.tsx

@@ -52,8 +52,6 @@ export const PeoplePaneContent = (props: {
   // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
   const getStrings = () => {
     return localeStrings.strings.call;
-
-    return localeStrings.strings.callWithChat;
   };
   const strings = getStrings();
 

packages/react-composites/src/composites/common/VideoEffectsPane.tsx

@@ -198,7 +198,6 @@ const VideoEffectsPaneTrampoline = (
       />
     </Stack>
   );
-  return <></>;
 };
 
 const backgroundPickerStyles = {