Skip to content

Commit 2f7f309

Browse files
Fix bug where 'in this call' text is incorrectly wrapped inside h2 tag (#6010)
* Fix bug where 'in this call' text is incorrectly wrapped inside h2 tag * add missing style * Update packages/react-composites CallWithChatComposite browser test snapshots * Update packages/react-composites ChatComposite browser test snapshots * Update packages/react-composites CallWithChatComposite browser test snapshots * Update embed html bundle snapshots * Update packages/react-composites CallComposite browser test snapshots * Update packages/react-composites CallComposite browser test snapshots * Update so styling is not changed * Revert "Update packages/react-composites CallWithChatComposite browser test snapshots" This reverts commit 2938650. * Revert "Update embed html bundle snapshots" This reverts commit c58a60d. * Revert "Update packages/react-composites CallComposite browser test snapshots" This reverts commit 3af21bc. * Revert "Update packages/react-composites CallComposite browser test snapshots" This reverts commit 62e3cca. * revert snapshots --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 8112431 commit 2f7f309

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Participant container",
5+
"comment": "Fix bug where 'in this call' text is incorrectly wrapped inside h2 tag",
6+
"packageName": "@azure/communication-react",
7+
"email": "[email protected]",
8+
"dependentChangeType": "patch"
9+
}

packages/react-composites/src/composites/common/ParticipantContainer.tsx

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,10 @@ export const ParticipantListWithHeading = (props: {
7171
const subheadingStyleThemed = useMemo(
7272
() => ({
7373
root: {
74-
h2: {
75-
color: theme.palette.neutralSecondary,
76-
margin: props.isMobile ? '0.5rem 1rem' : '0.5rem',
77-
fontSize: theme.fonts.smallPlus.fontSize,
78-
fontWeight: 'normal'
79-
}
74+
color: theme.palette.neutralSecondary,
75+
margin: props.isMobile ? '0.5rem 1rem' : '0.5rem',
76+
fontSize: theme.fonts.smallPlus.fontSize,
77+
fontWeight: 'normal'
8078
}
8179
}),
8280
[theme.palette.neutralSecondary, theme.fonts.smallPlus.fontSize, props.isMobile]
@@ -86,12 +84,10 @@ export const ParticipantListWithHeading = (props: {
8684
<Stack className={participantListStack}>
8785
<Stack horizontal horizontalAlign="space-between" verticalAlign="center">
8886
<Stack.Item grow styles={subheadingStyleThemed} aria-label={title} id={subheadingUniqueId}>
89-
<h2>
90-
{paneTitleTrampoline(
91-
title ?? '',
92-
/* @conditional-compile-remove(total-participant-count) */ totalParticipantCount
93-
)}
94-
</h2>
87+
{paneTitleTrampoline(
88+
title ?? '',
89+
/* @conditional-compile-remove(total-participant-count) */ totalParticipantCount
90+
)}
9591
</Stack.Item>
9692
{(onClickHeadingMoreButton ||
9793
(headingMoreButtonMenuProps?.items && headingMoreButtonMenuProps.items.length > 0)) && (

0 commit comments

Comments
 (0)