Ensure storybook 8 builds with default build commands and do not generate s6 PR links (#5220)

* Default to storybook 8 building and do not generate s6 PR links

* Update deployment target

* revert lint change as there are so many lint fixes need to be seperate pr

Author: JamesBurnside

.github/workflows/ci.yml

@@ -20,24 +20,6 @@ concurrency:
 permissions: read-all
 
 jobs:
-  files_changed:
-    name: Determine Changes
-    runs-on: ubuntu-latest
-    timeout-minutes: 3
-    # Map a step output to a job output
-    outputs:
-      storybook8_changes: ${{ steps.changes.outputs.storybook8 }}
-    steps:
-      # Checks-out your repository under $GITHUB_WORKSPACE so job can access it
-      - uses: actions/checkout@v4
-      - uses: dorny/paths-filter@v3
-        id: changes
-        with:
-          # token: ${{ secrets.GITHUB_TOKEN }}
-          filters: |
-            storybook8:
-              - 'packages/storybook8/**'
-
   # get matrix for ci-jobs
   get_matrix:
     name: Load CI Matrix Details
@@ -566,8 +548,7 @@ jobs:
         working-directory: packages/storybook
 
   build_storybook8:
-    needs: [get_matrix, files_changed]
-    if: needs.files_changed.outputs.storybook8_changes == 'true'
+    needs: get_matrix
     name: Build Storybook v8 (${{ matrix.flavor }})
     strategy:
       matrix: ${{ fromJSON(needs.get_matrix.outputs.matrix) }}
@@ -590,11 +571,11 @@ jobs:
         run: rush install --max-install-attempts 3
       - name: Build
         if: ${{ matrix.flavor == 'beta' || matrix.flavor == 'beta-release' }}
-        run: rushx build-s8
+        run: rushx build
         working-directory: packages/storybook8
       - name: Tests
         if: ${{ matrix.flavor == 'beta' || matrix.flavor == 'beta-release' }}
-        run: rushx test-s8
+        run: rushx test
         working-directory: packages/storybook8
 
   build_calling_sample:

.github/workflows/deploy-storybook.yml

@@ -48,14 +48,14 @@ jobs:
         # storybook requires the env vars to be in a .env file for access in the manager.ts
         run: |
           echo TELEMETRY_INSTRUMENTATION_KEY=${{ secrets.TELEMETRY_INSTRUMENTATION_KEY }} > .env
-        working-directory: ./packages/storybook
+        working-directory: ./packages/storybook8
         env:
           GH_TOKEN: ${{ github.actor }}:${{ secrets.GITHUB_TOKEN }}
 
       - name: Upload Storybook GH Pages Artifact
         uses: actions/upload-pages-artifact@v3
         with:
-          path: ./packages/storybook/storybook-static
+          path: ./packages/storybook8/storybook-static
 
       - name: Deploy to GitHub Pages
         uses: actions/deploy-pages@v4

.github/workflows/publish-chromatic.yml

@@ -3,7 +3,6 @@ name: 'Publish Chromatic'
 on:
   pull_request:
     paths:
-      - packages/storybook/**
       - packages/storybook8/**
       - packages/react-components/**
       - packages/react-composites/**
@@ -19,66 +18,6 @@ concurrency:
 
 jobs:
   chromatic_deployment:
-    name: Publish Chromatic Storybook 6
-    runs-on: ubuntu-latest
-    permissions:
-      packages: write
-      pull-requests: write
-    steps:
-      - uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-
-      - name: Use Node.js 20.x
-        uses: actions/setup-node@v4
-        with:
-          node-version: 20.x
-
-      - name: Restore node_modules from cache
-        uses: actions/cache@v4
-        with:
-          path: common/temp/pnpm-store
-          key: ${{ runner.os }}-${{ hashFiles('common/config/rush/pnpm-lock.yaml') }}
-
-      - name: Install Rush
-        run: npm install -g @microsoft/rush@$(jq -r '.rushVersion' "rush.json")
-
-      - name: Install Dependencies
-        run: rush install --max-install-attempts 3
-
-      - name: Publish Chromatic
-        id: publish_chromatic
-        uses: chromaui/action@v1
-        with:
-          workingDir: ./packages/storybook
-          buildScriptName: build:dev
-          token: ${{ secrets.GITHUB_TOKEN }}
-          projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
-          allowConsoleErrors: true
-
-      - name: Format storybook URL
-        id: storybook_url
-        # Get the url from chromatic job then remove the iframe.html at the end of the url (this looks like a bug)
-        run: |
-          storybookurl=${{ steps.publish_chromatic.outputs.storybookUrl }}
-          echo "Storybook URL before: $storybookurl"
-          newurl=${storybookurl/%iframe.html}
-          echo "Storybook URL after: $newurl"
-          echo "url=$newurl" >> $GITHUB_OUTPUT
-
-      - name: Add Storybook URL as Issue Comment
-        if: github.event_name == 'pull_request'
-        uses: actions/github-script@v3
-        with:
-          github-token: ${{secrets.GITHUB_TOKEN}}
-          script: |
-            github.issues.createComment({
-              issue_number: context.issue.number,
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: 'Storybook 6 URL ${{ steps.storybook_url.outputs.url }}'
-            })
-  chromatic_deployment8:
     name: Publish Chromatic Storybook 8
     runs-on: ubuntu-latest
     permissions:
@@ -111,7 +50,7 @@ jobs:
         uses: chromaui/action@v1
         with:
           workingDir: ./packages/storybook8
-          buildScriptName: build:dev-s8
+          buildScriptName: build:dev
           token: ${{ secrets.GITHUB_TOKEN }}
           projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
           allowConsoleErrors: true

packages/storybook8/package.json

@@ -3,15 +3,12 @@
   "version": "1.20.0-beta.0",
   "description": "Azure Communication Services UI Library Storybook",
   "scripts": {
-    "build": "echo Storybook 8 build via 'build-s8' target",
-    "build:dev": "echo Storybook 8 build via 'build:dev-s8' target",
-    "build-s8": "cross-env NODE_ENV=production node ./scripts/build.mjs",
-    "build:dev-s8": "cross-env NODE_ENV=development node ./scripts/build.mjs",
+    "build": "cross-env NODE_ENV=production node ./scripts/build.mjs",
+    "build:dev": "cross-env NODE_ENV=development node ./scripts/build.mjs",
     "clean": "",
     "start": "cross-env NODE_ENV=development node ./scripts/start.mjs",
     "storybook": "storybook",
-    "test": "echo Storybook 8 test via 'test-s8' target",
-    "test-s8": "node ./scripts/test.mjs",
+    "test": "node ./scripts/test.mjs",
     "test:ci-coverage": "echo skip",
     "test:coverage": "rushx test --coverage --coverageReporters=lcov",
     "test:snippets": "tsc --p tsconfig.snippets.json",