Skip to content

Commit 9766828

Browse files
authored
Merge branch 'main' into emlyn/oce-dep-updates
2 parents 26fad76 + 9ae5658 commit 9766828

File tree

4 files changed

+32
-14
lines changed

4 files changed

+32
-14
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Hard mute",
5+
"comment": "fix media access hermetic test",
6+
"packageName": "@azure/communication-react",
7+
"email": "[email protected]",
8+
"dependentChangeType": "patch"
9+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Hard mute",
5+
"comment": "fix media access hermetic test",
6+
"packageName": "@azure/communication-react",
7+
"email": "[email protected]",
8+
"dependentChangeType": "patch"
9+
}

packages/react-composites/tests/browser/call/hermetic/MediaAccess.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ test.describe('Media access mic/camera forbid/permit tests', async () => {
1717
const initialState = defaultMockCallAdapterState(participants, 'Presenter', false, undefined, true);
1818

1919
await page.goto(buildUrlWithMockAdapter(serverUrl, initialState, { newControlBarExperience: 'true' }));
20-
await page.pause();
20+
2121
if (isTestProfileMobile(testInfo)) {
2222
await waitForSelector(page, dataUiId(IDS.microphoneButton));
2323
await waitForSelector(page, dataUiId(IDS.cameraButton));
@@ -51,7 +51,7 @@ test.describe('Media access mic/camera forbid/permit tests', async () => {
5151
}
5252

5353
await page.goto(buildUrlWithMockAdapter(serverUrl, initialState, { newControlBarExperience: 'true' }));
54-
await page.pause();
54+
5555
if (isTestProfileMobile(testInfo)) {
5656
await waitForSelector(page, dataUiId(IDS.microphoneButton));
5757
await waitForSelector(page, dataUiId(IDS.cameraButton));

packages/react-composites/tests/browser/call/hermetic/fixture.ts

+12-12
Original file line numberDiff line numberDiff line change
@@ -322,33 +322,33 @@ const getCapabilitiesFromRole = (
322322
): CapabilitiesFeatureState | undefined => {
323323
if (isReactionCapability) {
324324
return {
325-
capabilities: presenterCapabilitiesInTeamsCall,
325+
capabilities: presenterCapabilitiesInTeamsCall(),
326326
latestCapabilitiesChangeInfo: { oldValue: {}, newValue: {}, reason: 'RoleChanged' }
327327
};
328328
}
329329

330330
switch (role) {
331331
case 'Attendee':
332332
return {
333-
capabilities: attendeeCapabilitiesInRoomsCall,
333+
capabilities: attendeeCapabilitiesInRoomsCall(),
334334
latestCapabilitiesChangeInfo: { oldValue: {}, newValue: {}, reason: 'RoleChanged' }
335335
};
336336
case 'Consumer':
337337
return {
338-
capabilities: consumerCapabilitiesInRoomsCall,
338+
capabilities: consumerCapabilitiesInRoomsCall(),
339339
latestCapabilitiesChangeInfo: { oldValue: {}, newValue: {}, reason: 'RoleChanged' }
340340
};
341341
case 'Presenter':
342342
return {
343-
capabilities: presenterCapabilitiesInRoomsCall,
343+
capabilities: presenterCapabilitiesInRoomsCall(),
344344
latestCapabilitiesChangeInfo: { oldValue: {}, newValue: {}, reason: 'RoleChanged' }
345345
};
346346
default:
347347
return undefined;
348348
}
349349
};
350350

351-
const consumerCapabilitiesInRoomsCall: ParticipantCapabilities = {
351+
const consumerCapabilitiesInRoomsCall = (): ParticipantCapabilities => ({
352352
addCommunicationUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
353353
addPhoneNumber: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
354354
addTeamsUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
@@ -398,9 +398,9 @@ const consumerCapabilitiesInRoomsCall: ParticipantCapabilities = {
398398
isPresent: false,
399399
reason: 'CapabilityNotApplicableForTheCallType'
400400
}
401-
};
401+
});
402402

403-
const attendeeCapabilitiesInRoomsCall: ParticipantCapabilities = {
403+
const attendeeCapabilitiesInRoomsCall = (): ParticipantCapabilities => ({
404404
addCommunicationUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
405405
addPhoneNumber: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
406406
addTeamsUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
@@ -450,9 +450,9 @@ const attendeeCapabilitiesInRoomsCall: ParticipantCapabilities = {
450450
isPresent: false,
451451
reason: 'CapabilityNotApplicableForTheCallType'
452452
}
453-
};
453+
});
454454

455-
const presenterCapabilitiesInRoomsCall: ParticipantCapabilities = {
455+
const presenterCapabilitiesInRoomsCall = (): ParticipantCapabilities => ({
456456
addCommunicationUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
457457
addPhoneNumber: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
458458
addTeamsUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
@@ -502,9 +502,9 @@ const presenterCapabilitiesInRoomsCall: ParticipantCapabilities = {
502502
isPresent: false,
503503
reason: 'CapabilityNotApplicableForTheCallType'
504504
}
505-
};
505+
});
506506

507-
const presenterCapabilitiesInTeamsCall: ParticipantCapabilities = {
507+
const presenterCapabilitiesInTeamsCall = (): ParticipantCapabilities => ({
508508
addCommunicationUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
509509
addPhoneNumber: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
510510
addTeamsUser: { isPresent: false, reason: 'CapabilityNotApplicableForTheCallType' },
@@ -554,7 +554,7 @@ const presenterCapabilitiesInTeamsCall: ParticipantCapabilities = {
554554
isPresent: true,
555555
reason: 'CapabilityNotApplicableForTheCallType'
556556
}
557-
};
557+
});
558558

559559
const defaultEndedCallState: CallState = {
560560
id: 'call0',

0 commit comments

Comments
 (0)