Skip to content

Commit f06b904

Browse files
[Calling][Bug] Disable PPTLive keyboard by adding overlay (#4349)
* Disable keyboard * Change files * Duplicate change files for beta release * remove the pptlive * refactor style * Refactor the videoTile logic * add comments * format the file * clean up the feature.js * Update the commands --------- Co-authored-by: Donald McEachern <[email protected]>
1 parent 01b7f8f commit f06b904

File tree

4 files changed

+42
-0
lines changed

4 files changed

+42
-0
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Disbale the PPTLive keyboard navigation",
5+
"comment": "Disable keyboard",
6+
"packageName": "@azure/communication-react",
7+
"email": "[email protected]",
8+
"dependentChangeType": "patch"
9+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
{
2+
"type": "patch",
3+
"area": "fix",
4+
"workstream": "Disbale the PPTLive keyboard navigation",
5+
"comment": "Disable keyboard",
6+
"packageName": "@azure/communication-react",
7+
"email": "[email protected]",
8+
"dependentChangeType": "patch"
9+
}

packages/react-components/src/components/VideoTile.tsx

+7
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ import { moreButtonStyles } from './styles/VideoTile.styles';
4141
import { raiseHandContainerStyles } from './styles/VideoTile.styles';
4242
/* @conditional-compile-remove(reaction) */
4343
import { ReactionResources } from '../types/ReactionTypes';
44+
/* @conditional-compile-remove(ppt-live) */
45+
import { pptLiveOverlayStyles } from './styles/VideoGallery.styles';
4446

4547
/**
4648
* Strings of {@link VideoTile} that can be overridden.
@@ -404,6 +406,11 @@ export const VideoTile = (props: VideoTileProps): JSX.Element => {
404406
/* @conditional-compile-remove(reaction) */
405407
reactionOverlay
406408
}
409+
{
410+
/* @conditional-compile-remove(ppt-live) */
411+
// TODO Can be removed once the overlay mitigation has been implemented at the SDK layer
412+
<Stack className={mergeStyles(videoContainerStyles, pptLiveOverlayStyles)}></Stack>
413+
}
407414
{(canShowLabel || participantStateString) && (
408415
<Stack horizontal className={tileInfoContainerStyle} tokens={tileInfoContainerTokens}>
409416
<Stack horizontal className={tileInfoStyle}>

packages/react-components/src/components/styles/VideoGallery.styles.ts

+17
Original file line numberDiff line numberDiff line change
@@ -59,3 +59,20 @@ export const localVideoCameraCycleButtonStyles = (theme: Theme, size?: 'small' |
5959
export const localVideoTileContainerStyles: IStackStyles = {
6060
root: { width: '100%', height: '100%' }
6161
};
62+
63+
/**
64+
* @private
65+
*/
66+
//TODO Can be removed once the overlay mitigation has been implemented at the SDK layer
67+
export const pptLiveOverlayStyles: IStackStyles = {
68+
root: {
69+
position: 'absolute',
70+
top: 0,
71+
left: 0,
72+
width: '100%',
73+
height: '100%',
74+
backgroundColor: 'transparent',
75+
pointerEvents: 'none',
76+
zIndex: 0
77+
}
78+
};

0 commit comments

Comments
 (0)