Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete type definition for CallAndChatLocator #5689

Open
adrian-crisan625 opened this issue Mar 7, 2025 · 1 comment
Open

Incomplete type definition for CallAndChatLocator #5689

adrian-crisan625 opened this issue Mar 7, 2025 · 1 comment
Assignees

Comments

@adrian-crisan625
Copy link

Describe the bug; what happened?
The interface CallAndChatLocator only supports GroupCallLocator type for the callLocator field

What are the steps to reproduce the issue?
Install npm package @azure/communication-react, version 1.22.0

What behavior did you expect?
I can set a RoomCallLocator in the callLocator field in interface CallAndChatLocator . The CallAdapterLocator used by the CallComposite does support this.

If applicable, provide screenshots:

In what environment did you see the issue?

  • @azure/communication-react npm package version 1.22.0
  • OS & Device: Win 11, PC
  • Browser: Any
  • Browser Version: Any

Is there any additional information?

@mgamis-msft
Copy link
Contributor

mgamis-msft commented Mar 10, 2025

Hi @adrian-crisan625, Thanks for filing this issue. RoomCallLocator was not intended to be included in CallAndChatLocator because the rooms does not yet support chat threads. While technically it is possible to create a chat thread for a rooms call, there would be no access control done by the Rooms client as of today and any ACS user could join that chat thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants