Skip to content

Commit 11b30c1

Browse files
authored
Merge pull request #216 from bd-andrew-young/upgrade-sqlclient-driver-to-Microsoft.Data.SqlClient
Upgrade sqlclient driver to 2.1.2
2 parents 9ce7614 + 3b4fb07 commit 11b30c1

File tree

5 files changed

+14
-5
lines changed

5 files changed

+14
-5
lines changed

Src/ElasticScale.Client/Microsoft.Azure.SqlDatabase.ElasticScale.Client.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<RuntimeIdentifiers>win;unix</RuntimeIdentifiers>
2020
<RootNamespace>Microsoft.Azure.SqlDatabase.ElasticScale</RootNamespace>
2121
</PropertyGroup>
22-
22+
2323
<Import Project="$([MSBuild]::GetPathOfFileAbove('build.props'))" />
2424
<Import Project="$([MSBuild]::GetPathOfFileAbove('strongname.props'))" />
2525

@@ -50,7 +50,7 @@
5050

5151
<ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' ">
5252
<PackageReference Include="Microsoft.Data.SqlClient">
53-
<Version>1.1.1</Version>
53+
<Version>2.1.2</Version>
5454
</PackageReference>
5555
</ItemGroup>
5656

Src/ElasticScale.Client/ShardManagement/ShardMap/ShardMapUtils.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,10 @@ internal static class ShardMapUtils
4343
/// because it may not be available in the .NET framework version that we are running in
4444
/// </summary>
4545
internal static readonly string ActiveDirectoryInteractiveStr = "ActiveDirectoryInteractive";
46+
internal static readonly string ActiveDirectoryServicePrincipal = "ActiveDirectoryServicePrincipal";
47+
internal static readonly string ActiveDirectoryDeviceCodeFlow = "ActiveDirectoryDeviceCodeFlow";
48+
internal static readonly string ActiveDirectoryManagedIdentity = "ActiveDirectoryManagedIdentity";
49+
internal static readonly string ActiveDirectoryMSI = "ActiveDirectoryMSI";
4650

4751
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Performance", "CA1810:InitializeReferenceTypeStaticFieldsInline")]
4852
static ShardMapUtils()

Src/ElasticScale.Client/ShardManagement/SqlStore/SqlShardMapManagerCredentials.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,12 @@ internal static void EnsureCredentials(
166166
{
167167
string authentication = connectionString[ShardMapUtils.Authentication].ToString();
168168
if (authentication.Equals(ShardMapUtils.ActiveDirectoryIntegratedStr, StringComparison.OrdinalIgnoreCase)
169-
|| authentication.Equals(ShardMapUtils.ActiveDirectoryInteractiveStr, StringComparison.OrdinalIgnoreCase))
169+
|| authentication.Equals(ShardMapUtils.ActiveDirectoryInteractiveStr, StringComparison.OrdinalIgnoreCase)
170+
|| authentication.Equals(ShardMapUtils.ActiveDirectoryManagedIdentity, StringComparison.OrdinalIgnoreCase)
171+
|| authentication.Equals(ShardMapUtils.ActiveDirectoryServicePrincipal, StringComparison.OrdinalIgnoreCase)
172+
|| authentication.Equals(ShardMapUtils.ActiveDirectoryDeviceCodeFlow, StringComparison.OrdinalIgnoreCase)
173+
|| authentication.Equals(ShardMapUtils.ActiveDirectoryMSI, StringComparison.OrdinalIgnoreCase)
174+
)
170175
{
171176
return;
172177
}

Test/ElasticScale.ClientTestCommon/Microsoft.Azure.SqlDatabase.ElasticScale.ClientTestCommon.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,6 @@
88
<PackageReference Include="MSTest.TestFramework" Version="2.1.0" />
99
</ItemGroup>
1010
<ItemGroup>
11-
<PackageReference Include="Microsoft.Data.SqlClient" Version="1.1.1" />
11+
<PackageReference Include="Microsoft.Data.SqlClient" Version="2.1.2" />
1212
</ItemGroup>
1313
</Project>

Test/ElasticScale.Query.UnitTests/Microsoft.Azure.SqlDatabase.ElasticScale.Query.UnitTests.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
1010
<PackageReference Include="MSTest.TestAdapter" Version="2.1.0" />
1111
<PackageReference Include="MSTest.TestFramework" Version="2.1.0" />
12-
<PackageReference Include="Microsoft.Data.SqlClient" Version="1.1.1" />
12+
<PackageReference Include="Microsoft.Data.SqlClient" Version="2.1.2" />
1313
</ItemGroup>
1414
<ItemGroup>
1515
<ProjectReference Include="..\..\Src\ElasticScale.Client\Microsoft.Azure.SqlDatabase.ElasticScale.Client.csproj" />

0 commit comments

Comments
 (0)