address comments

Author: unpluggedk

IdentityCore/src/MSIDError.m

@@ -84,8 +84,6 @@ MSIDErrorCode MSIDErrorCodeForOAuthError(NSString *oauthError, MSIDErrorCode def
 
                       // Authority Validation Errors
                       @(MSIDErrorAuthorityValidation),
-                      @(MSIDErrorAuthorityValidation),
-                      @(MSIDErrorAuthorityValidation),
 
                       // Interactive flow errors
                       @(MSIDErrorAuthorizationFailed),

IdentityCore/src/webview/MSIDWebviewAuthorization.m

@@ -83,7 +83,7 @@ + (void)startSession:(MSIDWebviewSession *)session
     // check session nil
     if (!session)
     {
-        NSError *error = MSIDCreateError(MSIDErrorDomain, MSIDErrorInvalidDeveloperParameter, @"Interactive session failed to create.", nil, nil, nil, context.correlationId, nil);
+        NSError *error = MSIDCreateError(MSIDErrorDomain, MSIDErrorInternal, @"Interactive session failed to create.", nil, nil, nil, context.correlationId, nil);
         completionHandler(nil, error);
         return;
     }

IdentityCore/src/webview/embeddedWebview/ui/ios/MSIDWebviewUIController.m

@@ -170,14 +170,15 @@ - (UIActivityIndicatorView *)prepareLoadingIndicator:(UIView *)rootView
     return loadingIndicator;
 }
 
+// This is reserved for subclass to handle programatic cancellation.
 - (void)cancel
 {
     // Overridden in subclass with cancel logic
 }
 
 - (void)userCancel
 {
-    // Overridden in subclass with cancel logic
+    // Overridden in subclass with userCancel logic
 }
 
 #pragma mark - Background task

IdentityCore/src/webview/embeddedWebview/ui/mac/MSIDWebviewUIController.m

@@ -166,14 +166,15 @@ - (NSProgressIndicator *)prepareLoadingIndicator
     return loadingIndicator;
 }
 
+// This is reserved for subclass to handle programatic cancellation.
 - (void)cancel
 {
     // Overridden in subclass with cancel logic
 }
 
 - (void)userCancel
 {
-    // Overridden in subclass with cancel logic
+    // Overridden in subclass with userCancel logic
 }
 
 

IdentityCore/tests/MSIDWebviewAuthorizationTests.m

@@ -79,7 +79,7 @@ - (void)testStartSession_whenSessionIsNil_shouldReturnErrorAtCompletionHandler
                          completionHandler:^(MSIDWebviewResponse *response, NSError *error) {
                              XCTAssertNil(response);
                              XCTAssertNotNil(error);
-                             XCTAssertEqual(error.code, MSIDErrorInvalidDeveloperParameter);
+                             XCTAssertEqual(error.code, MSIDErrorInternal);
 
                              [expectation fulfill];
                          }];