Skip to content

Commit

Permalink
Dashboard: Simplify imports (#837)
Browse files Browse the repository at this point in the history
* centralize vuetify import into dashboard/__init__.py

* centralize setup_server import

* simplify some more imports

* move some __main__.py imports to __init__.py

* centralize some analyze imports
  • Loading branch information
proy30 authored Feb 9, 2025
1 parent 73ab343 commit 0ef7039
Show file tree
Hide file tree
Showing 25 changed files with 93 additions and 70 deletions.
7 changes: 7 additions & 0 deletions src/python/impactx/dashboard/Analyze/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from .analyzeFunctions import AnalyzeFunctions
from .plot_ParameterEvolutionOverS.overS import line_plot_1d

__all__ = [
"AnalyzeFunctions",
"line_plot_1d",
]
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/Analyze/analyzeFunctions.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

import pandas as pd

from ..trame_setup import setup_server
from .. import setup_server

server, state, ctrl = setup_server()

Expand Down
7 changes: 3 additions & 4 deletions src/python/impactx/dashboard/Analyze/plotsMain.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,10 @@
import glob
import os

from trame.widgets import matplotlib, plotly, vuetify
from trame.widgets import matplotlib, plotly

from ..trame_setup import setup_server
from .analyzeFunctions import AnalyzeFunctions
from .plot_ParameterEvolutionOverS.overS import line_plot_1d
from .. import setup_server, vuetify
from . import AnalyzeFunctions, line_plot_1d

server, state, ctrl = setup_server()

Expand Down
5 changes: 0 additions & 5 deletions src/python/impactx/dashboard/Input/__init__.py
Original file line number Diff line number Diff line change
@@ -1,16 +1,11 @@
from trame.widgets import vuetify as vuetify

from ..trame_setup import setup_server
from .components import CardComponents, InputComponents, NavigationComponents
from .defaults import DashboardDefaults
from .generalFunctions import generalFunctions

__all__ = [
"InputComponents",
"CardComponents",
"vuetify",
"DashboardDefaults",
"NavigationComponents",
"generalFunctions",
"setup_server",
]
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/Input/components.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Optional

from . import setup_server, vuetify
from .. import setup_server, vuetify
from .generalFunctions import generalFunctions

server, state, ctrl = setup_server()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from .. import CardComponents, InputComponents, setup_server, vuetify
from ... import setup_server, vuetify
from .. import CardComponents, InputComponents

server, state, ctrl = setup_server()

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from .distributionFunctions import DistributionFunctions

__all__ = [
"DistributionFunctions",
]
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from ...trame_setup import setup_server
from ... import setup_server

server, state, ctrl = setup_server()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,9 @@

from impactx import distribution

from .. import (
CardComponents,
DashboardDefaults,
InputComponents,
generalFunctions,
setup_server,
vuetify,
)
from .distributionFunctions import DistributionFunctions
from ... import setup_server, vuetify
from .. import CardComponents, DashboardDefaults, InputComponents, generalFunctions
from . import DistributionFunctions

server, state, ctrl = setup_server()

Expand Down
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/Input/generalFunctions.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import subprocess
import webbrowser

from ..trame_setup import setup_server
from .. import setup_server
from .defaults import DashboardDefaults

server, state, ctrl = setup_server()
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from .inputFunctions import InputFunctions

__all__ = [
"InputFunctions",
]
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
License: BSD-3-Clause-LBNL
"""

from ...trame_setup import setup_server
from ... import setup_server

server, state, ctrl = setup_server()

Expand Down
12 changes: 3 additions & 9 deletions src/python/impactx/dashboard/Input/inputParameters/inputMain.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,9 @@
License: BSD-3-Clause-LBNL
"""

from .. import (
CardComponents,
DashboardDefaults,
InputComponents,
generalFunctions,
setup_server,
vuetify,
)
from .inputFunctions import InputFunctions
from ... import setup_server, vuetify
from .. import CardComponents, DashboardDefaults, InputComponents, generalFunctions
from . import InputFunctions

server, state, ctrl = setup_server()

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,8 @@

from impactx import elements

from .. import (
CardComponents,
InputComponents,
NavigationComponents,
generalFunctions,
setup_server,
vuetify,
)
from ... import setup_server, vuetify
from .. import CardComponents, InputComponents, NavigationComponents, generalFunctions

server, state, ctrl = setup_server()

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
from .spaceChargeFunctions import SpaceChargeFunctions

__all__ = [
"SpaceChargeFunctions",
]
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
from ...trame_setup import setup_server
from ..generalFunctions import generalFunctions
from ... import setup_server
from .. import generalFunctions

server, state, ctrl = setup_server()

Expand Down
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
from .. import (
CardComponents,
InputComponents,
NavigationComponents,
generalFunctions,
setup_server,
vuetify,
)
from .spaceChargeFunctions import SpaceChargeFunctions
from ... import setup_server, vuetify
from .. import CardComponents, InputComponents, NavigationComponents, generalFunctions
from . import SpaceChargeFunctions

server, state, ctrl = setup_server()

Expand Down
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/Run/controls.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

from wurlitzer import pipes

from .. import setup_server
from ..simulation import run_simulation
from ..trame_setup import setup_server

server, state, ctrl = setup_server()

Expand Down
4 changes: 2 additions & 2 deletions src/python/impactx/dashboard/Toolbar/controls.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
License: BSD-3-Clause-LBNL
"""

from trame.widgets import html, vuetify
from trame.widgets import html

from .. import setup_server, vuetify
from ..Analyze.plotsMain import available_plot_options, load_dataTable_data, update_plot
from ..Input.generalFunctions import generalFunctions
from ..Run.controls import execute_impactx_sim
from ..trame_setup import setup_server
from .exportTemplate import input_file
from .importParser import DashboardParser

Expand Down
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/Toolbar/exportTemplate.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from .. import setup_server
from ..Input.distributionParameters.distributionFunctions import DistributionFunctions
from ..Input.latticeConfiguration.latticeMain import parameter_input_checker_for_lattice
from ..trame_setup import setup_server

server, state, ctrl = setup_server()

Expand Down
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/Toolbar/importParser.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from .. import setup_server
from ..Input.distributionParameters.distributionMain import (
on_distribution_parameter_change,
populate_distribution_parameters,
Expand All @@ -6,7 +7,6 @@
add_lattice_element,
on_lattice_element_parameter_change,
)
from ..trame_setup import setup_server
from .importParserHelper import DashboardParserHelper

server, state, ctrl = setup_server()
Expand Down
27 changes: 27 additions & 0 deletions src/python/impactx/dashboard/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,32 @@
from trame.widgets import vuetify as vuetify

# isort: off

from .trame_setup import setup_server
from .Toolbar.controls import GeneralToolbar

from .Analyze.plotsMain import AnalyzeSimulation
from .Input.csrConfiguration.csrMain import csrConfiguration
from .Input.distributionParameters.distributionMain import DistributionParameters
from .Input.inputParameters.inputMain import InputParameters
from .Input.latticeConfiguration.latticeMain import LatticeConfiguration
from .Input.components import NavigationComponents
from .Input.space_charge_configuration.spaceChargeMain import SpaceChargeConfiguration

from .jupyterApplication import JupyterMainApplication as JupyterApp
# isort: on


__all__ = [
"JupyterApp",
"setup_server",
"vuetify",
"AnalyzeSimulation",
"NavigationComponents",
"csrConfiguration",
"DistributionParameters",
"InputParameters",
"LatticeConfiguration",
"SpaceChargeConfiguration",
"GeneralToolbar",
]
25 changes: 14 additions & 11 deletions src/python/impactx/dashboard/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,21 @@

from trame.ui.router import RouterViewLayout
from trame.ui.vuetify import SinglePageWithDrawerLayout
from trame.widgets import router, vuetify, xterm

from .Analyze.plotsMain import AnalyzeSimulation
from .Input.components import NavigationComponents
from .Input.csrConfiguration.csrMain import csrConfiguration
from .Input.distributionParameters.distributionMain import DistributionParameters
from .Input.inputParameters.inputMain import InputParameters
from .Input.latticeConfiguration.latticeMain import LatticeConfiguration
from .Input.space_charge_configuration.spaceChargeMain import SpaceChargeConfiguration
from trame.widgets import router, xterm

from . import (
AnalyzeSimulation,
DistributionParameters,
GeneralToolbar,
InputParameters,
LatticeConfiguration,
NavigationComponents,
SpaceChargeConfiguration,
csrConfiguration,
setup_server,
vuetify,
)
from .start import main
from .Toolbar.controls import GeneralToolbar
from .trame_setup import setup_server

server, state, ctrl = setup_server()

Expand Down
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/simulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
License: BSD-3-Clause-LBNL
"""

from .trame_setup import setup_server
from . import setup_server

server, state, ctrl = setup_server()

Expand Down
2 changes: 1 addition & 1 deletion src/python/impactx/dashboard/start.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
License: BSD-3-Clause-LBNL
"""

from . import setup_server
from .Input.defaults import DashboardDefaults
from .trame_setup import setup_server

server, state, ctrl = setup_server()

Expand Down

0 comments on commit 0ef7039

Please sign in to comment.