Refactor to have max line size to 120.

Author: MissterP

autosubmit/performance/base_performance.py

@@ -47,9 +47,7 @@ class PerformanceMetricInfo(NamedTuple):
 class BasePerformance(ABC):
     """Base class for performance metrics calculation"""
 
-    _mail_notifier = MailNotifier(
-        BasicConfig()
-    )  # Default MailNotifier with BasicConfig
+    _mail_notifier = MailNotifier(BasicConfig())  # Default MailNotifier with BasicConfig
 
     def __init__(self, autosubmit_config: Optional[AutosubmitConfig] = None):
         """
@@ -61,9 +59,7 @@ def __init__(self, autosubmit_config: Optional[AutosubmitConfig] = None):
         self._autosubmit_config = autosubmit_config
 
     @abstractmethod
-    def compute_and_check_performance_metrics(
-        self, job: "Job"
-    ) -> list[PerformanceMetricInfo]:
+    def compute_and_check_performance_metrics(self, job: "Job") -> list[PerformanceMetricInfo]:
         """
         Compute performance metrics for a job.
 

autosubmit/performance/factory_performance.py

@@ -25,9 +25,7 @@
 
 class PerformanceFactory:
 
-    def create_performance(
-        self, job: "Job", config: AutosubmitConfig
-    ) -> BasePerformance:
+    def create_performance(self, job: "Job", config: AutosubmitConfig) -> BasePerformance:
         """
         Factory method to create a performance metric calculator for a job.
 
@@ -64,9 +62,7 @@ def create_performance(
         return self._create_performance_by_type(f"{job.section}_{project}", config)
 
     @staticmethod
-    def _create_performance_by_type(
-        job_type: str, config: AutosubmitConfig
-    ) -> BasePerformance:
+    def _create_performance_by_type(job_type: str, config: AutosubmitConfig) -> BasePerformance:
         """
         Create a performance calculator based on the job type.
 

autosubmit/performance/type_job/SIM/SIM_performance.py

@@ -16,10 +16,7 @@
 # along with Autosubmit.  If not, see <http://www.gnu.org/licenses/>.
 
 from typing import TYPE_CHECKING
-from autosubmit.performance.base_performance import (
-    BasePerformance,
-    PerformanceMetricInfo,
-)
+from autosubmit.performance.base_performance import BasePerformance,PerformanceMetricInfo
 
 if TYPE_CHECKING:
     from autosubmit.job.job import Job
@@ -35,9 +32,7 @@ class SIMPerformance(BasePerformance):
 
     # Errors management for each metric
 
-    def _manage_errors_computation_SYPD(
-        start_timestamp, finish_timestamp, chunk_size, chunk_size_unit
-    ):
+    def _manage_errors_computation_SYPD(start_timestamp, finish_timestamp, chunk_size, chunk_size_unit):
         """
         Manage errors in the computation of SYPD.
 
@@ -51,37 +46,23 @@ def _manage_errors_computation_SYPD(
             ValueError: If any of the parameters are invalid.
         """
 
-        if not (
-            start_timestamp and finish_timestamp and chunk_size and chunk_size_unit
-        ):
-            raise ValueError(
-                "Job must have start_time_timestamp, finish_time_timestamp, parameters ['EXPERIMENT']['CHUNKSIZE'] and parameters ['EXPERIMENT']['CHUNKSIZEUNIT'] set."
-            )
+        if not (start_timestamp and finish_timestamp and chunk_size and chunk_size_unit):
+            raise ValueError("Job must have start_time_timestamp, finish_time_timestamp, parameters ['EXPERIMENT']['CHUNKSIZE'] and parameters ['EXPERIMENT']['CHUNKSIZEUNIT'] set.")
 
         if not isinstance(start_timestamp, int):
-            raise TypeError(
-                "start_timestamp must be an integer representing Unix timestamp."
-            )
+            raise TypeError("start_timestamp must be an integer representing Unix timestamp.")
 
         if not isinstance(finish_timestamp, int):
-            raise TypeError(
-                "finish_timestamp must be an integer representing Unix timestamp."
-            )
+            raise TypeError("finish_timestamp must be an integer representing Unix timestamp.")
 
         if not isinstance(chunk_size, str):
-            raise TypeError(
-                "chunk_size must be a string representing the size of the chunk (e.g., '12')."
-            )
+            raise TypeError("chunk_size must be a string representing the size of the chunk (e.g., '12').")
 
         if not isinstance(chunk_size_unit, str):
-            raise TypeError(
-                "chunk_size_unit must be a string representing the unit of the chunk size (e.g., 'month')."
-            )
+            raise TypeError("chunk_size_unit must be a string representing the unit of the chunk size (e.g., 'month').")
 
         if not chunk_size.isdigit() or int(chunk_size) <= 0:
-            raise ValueError(
-                "chunk_size must be a positive numeric string (e.g., '12')."
-            )
+            raise ValueError("chunk_size must be a positive numeric string (e.g., '12').")
 
     # Computation and check of SYPD
 
@@ -102,9 +83,7 @@ def compute_sypd_from_job(job: "Job") -> float:
         chunk_size = job.parameters["EXPERIMENT"]["CHUNKSIZE"]
         chunk_size_unit = job.parameters["EXPERIMENT"]["CHUNKSIZEUNIT"]
 
-        SIMPerformance._manage_errors_computation_SYPD(
-            start_timestamp, finish_timestamp, chunk_size, chunk_size_unit
-        )
+        SIMPerformance._manage_errors_computation_SYPD(start_timestamp, finish_timestamp, chunk_size, chunk_size_unit)
 
         duration_seconds = finish_timestamp - start_timestamp
 
@@ -150,9 +129,7 @@ def compute_and_check_SYPD_threshold(self, job: "Job") -> PerformanceMetricInfo:
 
     # Computation and check of performance metrics
 
-    def compute_and_check_performance_metrics(
-        self, job: "Job"
-    ) -> list[PerformanceMetricInfo]:
+    def compute_and_check_performance_metrics(self, job: "Job") -> list[PerformanceMetricInfo]:
         """
         Compute the performance metrics for a job and check if it is under a threshold.
 

autosubmit/performance/type_job/SIM/project/SIM_DestinE.py

@@ -31,9 +31,7 @@ class SIMDestinEPerformance(SIMPerformance):
 
     SYPD_THRESHOLD: float = 2  # Threshold for SYPD to consider a job as "fast"
 
-    def compute_and_check_performance_metrics(
-        self, job: "Job"
-    ) -> list[PerformanceMetricInfo]:
+    def compute_and_check_performance_metrics(self, job: "Job") -> list[PerformanceMetricInfo]:
         """
         Compute the performance metrics for a SIM DestinE job and check if it is under a threshold.
 

test/unit/performance/conftest.py

@@ -100,7 +100,7 @@ def mock_smtp(mocker):
 
 
 @pytest.fixture
-def mock_mail_notifier(mock_basic_config):
+def mock_mail_notifier(mock_basic_config) -> MailNotifier:
     """
     Fixture to create a MailNotifier instance with mocked BasicConfig.
     """