CSCDESTINCLIMADT-794: Force the function get_in_queue_grouped_id to return a list.

- Added mypy types
- Added unit and integration tests
- Changed the order at which ``JobList.save_wrappers`` is called in
  ``autosubmit/autosubmit.py``
- Added docstrings, and fixed linter errors (to debug/see code
  execution)

Author: kinow

CHANGELOG.md

@@ -3,6 +3,7 @@
 **Bug fixes:**
 
 - Fixed issue with the verification of dirty Git local repositories in operational experiments #2446
+- Fixed "Unexpected error: 'list' object has no attribute 'status'" when running experiments #2463
 
 **Enhancements:**
 

autosubmit/autosubmit.py

@@ -1594,14 +1594,14 @@ def check_wrapper_conf(self, wrappers=None, no_log=False):
                 if 'horizontal' in self.get_wrapper_type(wrapper_values):
                     if not self.experiment_data["PLATFORMS"][platform_name].get('PROCESSORS_PER_NODE', None):
                         self.wrong_config["WRAPPERS"] += [
-                            [wrapper_name, "PROCESSORS_PER_NODE no exist in the horizontal-wrapper platform"]]
+                            [wrapper_name, "PROCESSORS_PER_NODE does not exist in the horizontal-wrapper platform"]]
                     if not self.experiment_data["PLATFORMS"][platform_name].get('MAX_PROCESSORS', ""):
                         self.wrong_config["WRAPPERS"] += [[wrapper_name,
-                                                           "MAX_PROCESSORS no exist in the horizontal-wrapper platform"]]
+                                                           "MAX_PROCESSORS does not exist in the horizontal-wrapper platform"]]
                 if 'vertical' in self.get_wrapper_type(wrapper_values):
                     if not self.experiment_data.get("PLATFORMS", {}).get(platform_name, {}).get('MAX_WALLCLOCK', ""):
                         self.wrong_config["WRAPPERS"] += [[wrapper_name,
-                                                           "MAX_WALLCLOCK no exist in the vertical-wrapper platform"]]
+                                                           "MAX_WALLCLOCK does not exist in the vertical-wrapper platform"]]
             if "WRAPPERS" not in self.wrong_config:
                 if not no_log:
                     Log.result('wrappers OK')
@@ -2558,6 +2558,8 @@ def get_remote_dependencies(self) -> str:
         """
         # Disabled, forced to "false" not working anymore in newer slurm versions.
         # return str(self.get_section(['CONFIG', 'PRESUBMISSION'], "false")).lower()
+        # FIXME: deprecate and/or remove PRESUBMISSION as it's not working on Slurm now?
+        #        https://github.com/BSC-ES/autosubmit/issues/2548
         return "false"
 
     def get_wrapper_type(self, wrapper=None) -> Optional[str]:

autosubmit/config/configcommon.py

@@ -0,0 +1,18 @@
+# Copyright 2015-2025 Earth Sciences Department, BSC-CNS
+#
+# This file is part of Autosubmit.
+#
+# Autosubmit is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Autosubmit is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Autosubmit.  If not, see <http://www.gnu.org/licenses/>.
+
+"""Code to manage Autosubmit experiments."""

autosubmit/experiment/__init__.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 # Copyright 2015-2025 Earth Sciences Department, BSC-CNS
 #
 # This file is part of Autosubmit.
@@ -19,13 +17,13 @@
 
 import datetime
 import pwd
-from pathlib import Path
 import sqlite3
-from autosubmit.database.db_common import get_experiment_id
-from autosubmit.config.configcommon import AutosubmitConfig
+from pathlib import Path
+
 from autosubmit.config.basicconfig import BasicConfig
+from autosubmit.config.configcommon import AutosubmitConfig
 from autosubmit.config.yamlparser import YAMLParserFactory
-
+from autosubmit.database.db_common import get_experiment_id
 
 LOCAL_TZ = datetime.datetime.now(datetime.timezone.utc).astimezone().tzinfo
 

autosubmit/experiment/detail_updater.py

@@ -17,8 +17,13 @@
 
 """Module containing functions to manage autosubmit's experiments."""
 
+import os
+import pwd
 import string
+from pathlib import Path
+from typing import Optional
 
+from autosubmit.config.basicconfig import BasicConfig
 from autosubmit.database import db_common
 from autosubmit.log.log import Log, AutosubmitCritical
 
@@ -109,7 +114,6 @@ def copy_experiment(experiment_id, description, version, test=False, operational
                                  f"as a new experiment in the db: {e}", 7011) from e
 
 
-
 def next_experiment_id(current_id):
     """
     Get next experiment identifier
@@ -184,3 +188,31 @@ def base36decode(number):
     :rtype: int
     """
     return int(number, 36)
+
+
+def check_ownership(expid, raise_error=False) -> tuple[bool, bool, Optional[str]]:
+    """Check if the user owns and if it is eadmin.
+
+    :return: the owner, eadmin, and current_owner
+    """
+    current_owner: Optional[str] = None
+    current_owner_id = Path(BasicConfig.LOCAL_ROOT_DIR, expid).stat().st_uid
+    try:
+        current_owner = pwd.getpwuid(current_owner_id).pw_name
+    except (TypeError, KeyError) as e:
+        Log.warning(f"Current owner of experiment {expid} could not be retrieved. The owner is no longer in the "
+                    f"system database: {str(e)}")
+
+    eadmin: bool = False
+    admin_user = "eadmin"  # to be improved in #944
+    current_user_id = os.getuid()
+    try:
+        eadmin = current_user_id == pwd.getpwnam(admin_user).pw_uid
+    except Exception as e:
+        Log.info(f"Autosubmit admin user: {admin_user} is not set: {str(e)}")
+
+    owner: bool = current_owner_id == current_user_id
+    if not owner and raise_error:
+        raise AutosubmitCritical(f"You don't own the experiment {expid}.", 7012)
+
+    return owner, eadmin, current_owner

autosubmit/experiment/experiment_common.py

@@ -98,9 +98,9 @@ def _match_autosubmit_cmdline(cmdline: List[str], command='run', expid: Optional
     >>> _match_autosubmit_cmdline(['autosubmit', 'running', 'a000'])
 
     >>> _match_autosubmit_cmdline(['autosubmit', 'a000', 'run'])
-    #
-    >>> _match_autosubmit_cmdline(['autosubmit', 'run', 'a001'])
 
+    >>> _match_autosubmit_cmdline(['autosubmit', 'run', 'a001'])
+    'a001'
     >>> _match_autosubmit_cmdline(['autosubmit', 'run', 'experiment'])
 
     >>> _match_autosubmit_cmdline(['autosubmit', 'run', 'a000'], 'create')

autosubmit/helpers/processes.py

@@ -16,11 +16,10 @@
 # You should have received a copy of the GNU General Public License
 # along with Autosubmit.  If not, see <http://www.gnu.org/licenses/>.
 
-import collections
 import autosubmit.history.utils as HUtils
 import autosubmit.history.database_managers.database_models as Models
 from datetime import datetime, timedelta
-from json import dumps, loads
+from json import loads
 
 
 class JobData(object):

autosubmit/history/data_classes/job_data.py

@@ -19,7 +19,6 @@
 
 import os
 import textwrap
-import time
 from typing import Protocol, cast
 from autosubmit.config.basicconfig import BasicConfig
 import autosubmit.history.utils as HUtils
@@ -56,14 +55,6 @@ def _validate_status_database(self):
         )
         self.execute_statement_on_dbfile(self._as_times_file_path, create_table_query)
 
-    def print_current_table(self):
-        for experiment in self._get_experiment_status_content():
-            print(experiment)
-        if self.current_experiment_status_row:
-            print(("Current Row:\n\t" + self.current_experiment_status_row.name + "\n\t" +
-                   str(self.current_experiment_status_row.exp_id) +
-                   "\n\t" + self.current_experiment_status_row.status))
-
     def set_existing_experiment_status_as_running(self, expid):
         """ Set the experiment_status row as running. """
         self.update_exp_status(expid, Models.RunningStatus.RUNNING)
@@ -144,8 +135,6 @@ def delete_exp_status(self, expid):
 
 
 class ExperimentStatusDatabaseManager(Protocol):
-    def print_current_table(self): ...
-
     def is_running(self, time_condition=600): ...
 
     def set_existing_experiment_status_as_running(self, expid): ...