CSCDESTINCLIMADT-794: Force the function get_in_queue_grouped_id to return a list.

- Added mypy types
- Added unit and integration tests
- Changed the order at which ``JobList.save_wrappers`` is called in
  ``autosubmit/autosubmit.py``
- Added docstrings, and fixed linter errors (to debug/see code
  execution)

Author: kinow

CHANGELOG.md

@@ -26,6 +26,7 @@ release.
 - Fixed bug where an RO-Crate file would include itself in the archive, as well as other zip files.
   Now Autosubmit uses the pattern $expid-crate-$date-$time-$millisecond.zip, and ignores any ZIP files
   in the tmp/ASLOGS that start with $expid-crate and end with .zip #2692
+- Fixed "Unexpected error: 'list' object has no attribute 'status'" when running experiments #2463
 
 **Enhancements:**
 
@@ -168,7 +169,7 @@ the filter the jobs. Not using any value for `-fp` still returns all jobs.
 
 **Others:**
 - All autosubmit projects moved to Github.
-- Added Github actions for CI/CD.
+- Added GitHub actions for CI/CD.
 
 4.1.11 - Enhancements, New Features, Documentation, and Bug Fixes
 =================================================================
@@ -240,15 +241,13 @@ Others:
 - Fixes an issue with dependency not being linked.
 - Docs improved.
 
-
 4.1.8 - Bug fixes.
 ==================
 - Fixed an issue with a socket connection left open.
 - Fixed an issue with log recovery being disabled by default.
 - Added exclusive parameter
 - Fixed some X11 routines called by default
 
-
 4.1.7 - X11, Migrate, script and Bug fixes
 ==========================================
 - Migrate added, a feature to change the ownership of the experiments (/scratch and autosubmit_data paths)
@@ -296,9 +295,6 @@ Others:
 - Added RO-Crate.
 - Added Calendar for splits.
 
-
-
-
 4.1.2 - Bug fixes
 =================
 - Fixed issues with version.

autosubmit/autosubmit.py

@@ -1599,14 +1599,14 @@ def check_wrapper_conf(self, wrappers=None, no_log=False):
                 if 'horizontal' in self.get_wrapper_type(wrapper_values):
                     if not self.experiment_data["PLATFORMS"][platform_name].get('PROCESSORS_PER_NODE', None):
                         self.wrong_config["WRAPPERS"] += [
-                            [wrapper_name, "PROCESSORS_PER_NODE no exist in the horizontal-wrapper platform"]]
+                            [wrapper_name, "PROCESSORS_PER_NODE does not exist in the horizontal-wrapper platform"]]
                     if not self.experiment_data["PLATFORMS"][platform_name].get('MAX_PROCESSORS', ""):
                         self.wrong_config["WRAPPERS"] += [[wrapper_name,
-                                                           "MAX_PROCESSORS no exist in the horizontal-wrapper platform"]]
+                                                           "MAX_PROCESSORS does not exist in the horizontal-wrapper platform"]]
                 if 'vertical' in self.get_wrapper_type(wrapper_values):
                     if not self.experiment_data.get("PLATFORMS", {}).get(platform_name, {}).get('MAX_WALLCLOCK', ""):
                         self.wrong_config["WRAPPERS"] += [[wrapper_name,
-                                                           "MAX_WALLCLOCK no exist in the vertical-wrapper platform"]]
+                                                           "MAX_WALLCLOCK does not exist in the vertical-wrapper platform"]]
             if "WRAPPERS" not in self.wrong_config:
                 if not no_log:
                     Log.result('wrappers OK')
@@ -2497,7 +2497,7 @@ def get_notifications(self) -> str:
 
     # based on https://github.com/cbirajdar/properties-to-yaml-converter/blob/master/properties_to_yaml.py
     @staticmethod
-    def ini_to_yaml(root_dir: Path, ini_file: str) -> None:
+    def ini_to_yaml(root_dir: Path, ini_file: Union[str, Path]) -> None:
         # Based on http://stackoverflow.com/a/3233356
         def update_dict(original_dict: dict, updated_dict: collections.abc.Mapping) -> dict:
             for k, v in updated_dict.items():
@@ -2564,6 +2564,8 @@ def get_remote_dependencies(self) -> str:
         """
         # Disabled, forced to "false" not working anymore in newer slurm versions.
         # return str(self.get_section(['CONFIG', 'PRESUBMISSION'], "false")).lower()
+        # FIXME: deprecate and/or remove PRESUBMISSION as it's not working on Slurm now?
+        #        https://github.com/BSC-ES/autosubmit/issues/2548
         return "false"
 
     def get_wrapper_type(self, wrapper=None) -> Optional[str]:

autosubmit/config/configcommon.py

@@ -0,0 +1,18 @@
+# Copyright 2015-2025 Earth Sciences Department, BSC-CNS
+#
+# This file is part of Autosubmit.
+#
+# Autosubmit is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# Autosubmit is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Autosubmit.  If not, see <http://www.gnu.org/licenses/>.
+
+"""Code to manage Autosubmit experiments."""

autosubmit/experiment/__init__.py

@@ -1,5 +1,3 @@
-#!/usr/bin/env python3
-
 # Copyright 2015-2025 Earth Sciences Department, BSC-CNS
 #
 # This file is part of Autosubmit.
@@ -17,23 +15,22 @@
 # You should have received a copy of the GNU General Public License
 # along with Autosubmit.  If not, see <http://www.gnu.org/licenses/>.
 
-from abc import ABC, abstractmethod
 import datetime
 import pwd
-from pathlib import Path
 import sqlite3
+from abc import ABC, abstractmethod
+from pathlib import Path
 from typing import Any, Dict, Union
 
 from sqlalchemy import Table
-from autosubmit.database.db_common import get_connection_url, get_experiment_id
-from autosubmit.config.configcommon import AutosubmitConfig
+
 from autosubmit.config.basicconfig import BasicConfig
+from autosubmit.config.configcommon import AutosubmitConfig
 from autosubmit.config.yamlparser import YAMLParserFactory
-
+from autosubmit.database.db_common import get_connection_url, get_experiment_id
 from autosubmit.database.session import create_engine
 from autosubmit.database.tables import get_table_from_name
 
-
 LOCAL_TZ = datetime.datetime.now(datetime.timezone.utc).astimezone().tzinfo
 
 

autosubmit/experiment/detail_updater.py

@@ -17,9 +17,13 @@
 
 """Module containing functions to manage autosubmit's experiments."""
 
+import os
+import pwd
 import string
 from pathlib import Path
+from typing import Optional
 
+from autosubmit.config.basicconfig import BasicConfig
 from autosubmit.database import db_common
 from autosubmit.log.log import Log, AutosubmitCritical
 
@@ -205,3 +209,31 @@ def create_required_folders(exp_id: str, exp_folder: Path) -> None:
     required_dirs = ["conf", "pkl", "tmp", "tmp/ASLOGS", f"tmp/LOG_{exp_id}", "plot", "status"]
     for required_dir in required_dirs:
         Path(exp_folder / required_dir).mkdir(mode=dir_mode)
+
+
+def check_ownership(expid, raise_error=False) -> tuple[bool, bool, Optional[str]]:
+    """Check if the user owns and if it is eadmin.
+
+    :return: the owner, eadmin, and current_owner
+    """
+    current_owner: Optional[str] = None
+    current_owner_id = Path(BasicConfig.LOCAL_ROOT_DIR, expid).stat().st_uid
+    try:
+        current_owner = pwd.getpwuid(current_owner_id).pw_name
+    except (TypeError, KeyError) as e:
+        Log.warning(f"Current owner of experiment {expid} could not be retrieved. The owner is no longer in the "
+                    f"system database: {str(e)}")
+
+    eadmin: bool = False
+    admin_user = "eadmin"  # to be improved in #944
+    current_user_id = os.getuid()
+    try:
+        eadmin = current_user_id == pwd.getpwnam(admin_user).pw_uid
+    except Exception as e:
+        Log.info(f"Autosubmit admin user: {admin_user} is not set: {str(e)}")
+
+    owner: bool = current_owner_id == current_user_id
+    if not owner and raise_error:
+        raise AutosubmitCritical(f"You don't own the experiment {expid}.", 7012)
+
+    return owner, eadmin, current_owner